feat(decentralize): support deploying a local directory via --path#370
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
`decentralize --path` resolved the playground detail-page README from the typed directory itself, so the common `--path ./dist` usage silently missed the project README (which lives at the repo root). The moddable preflight already walks up to the repo root for the git origin, leaving moddable apps with a recorded `repository` but an empty `readme`. Resolve the README `cwd` from the enclosing git repo root via a new `findProjectRoot` (walks up for `.git`, falls back to the directory), matching how `deploy` passes its project root and keeping README + `repository` metadata on one anchor. Update the publish-prompt copy and changeset to match.
UtkarshBhardwaj007
force-pushed
the
gs-decentralize-local-path
branch
from
f6a4cc2 to
258c238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.