Skip to content

feat: sync decentralize prompts with deploy and clarify update banner#377

Merged
UtkarshBhardwaj007 merged 1 commit into
mainfrom
feat/signer-prompt-and-decentralize-sync
Jun 13, 2026
Merged

feat: sync decentralize prompts with deploy and clarify update banner#377
UtkarshBhardwaj007 merged 1 commit into
mainfrom
feat/signer-prompt-and-decentralize-sync

Conversation

@UtkarshBhardwaj007

Copy link
Copy Markdown
Member

Summary

Brings playground decentralize's interactive prompts in line with playground deploy, and tweaks the signer picker UX in both. Three user-driven changes plus a copy fix:

Signer picker (deploy + decentralize)

  • Phone signer is listed first and is the default cursor position (when logged in).
  • The "Dev signer earns no XP" warning now renders below the options and only while the dev signer is highlighted — it disappears when you move back to the phone signer.
  • Adds an optional onHighlight callback to the shared Select component to drive this.

decentralize synced with deploy

  • Magenta help boxes above the signer, domain, publish, and (new) tags prompts, reusing deploy's copy; the intro "About This Command" box is recolored to accent.
  • The "publish to the playground registry?" prompt now lists "yes" first and selects it by default.
  • New category-tag step + --tag flag (whitelisted to PLAYGROUND_TAGS, requires --playground on the headless path), threaded into the published app metadata and shown in the confirm summary.
  • PromptInfo lifted from DeployScreen into the shared theme so both screens use one component.

Update banner

  • Now reads Run pg update to update the CLI. (was "playground update to upgrade") to avoid the upgrade/update wording mismatch.

Testing

  • pnpm typecheck ✓ · pnpm format:check ✓ · pnpm lint:license ✓ · pnpm test ✓ (887 tests)
  • New pure-logic tests: signerNotice.test.ts (option order + warning predicate), decentralize/signerPrompt.test.ts, decentralize/index.test.ts (--tag requires --playground), decentralize/state.test.ts (tag-gating). Banner string assertions updated.
  • Reviewed via two rounds of code review; the one finding (missing tag row in the decentralize confirm summary) was validated and fixed.

Notes

  • The update banner intentionally uses the short pg alias per request; the rest of the CLI copy uses the full playground name.
  • run.ts's one-line tag passthrough is not unit-tested (its downstream metadata write is covered); turning on the publish branch in run.test.ts would need substantial extra mocks.

Signer pickers (deploy + decentralize): list the phone signer first with
the cursor defaulting to it, and move the "dev signer earns no XP" warning
below the options, shown only while the dev signer is highlighted. Adds an
optional onHighlight callback to the shared Select component.

decentralize: add the same magenta help boxes as deploy above the signer,
domain, publish, and a new tags prompt (recoloring the intro box to accent);
reorder the publish prompt so "yes" is first and default-selected; add a
category-tag step plus a --tag flag (whitelisted to PLAYGROUND_TAGS, requires
--playground on the headless path), threaded into the published metadata and
surfaced in the confirm summary. Lifts PromptInfo into the shared theme.

version banner: now reads "Run pg update to update the CLI." for clarity.
@UtkarshBhardwaj007 UtkarshBhardwaj007 merged commit 31ce61a into main Jun 13, 2026
20 checks passed
@UtkarshBhardwaj007 UtkarshBhardwaj007 deleted the feat/signer-prompt-and-decentralize-sync branch June 13, 2026 12:41
@github-actions

Copy link
Copy Markdown
Contributor

Dev build ready — try this branch:

curl -fsSL https://raw.githubusercontent.com/paritytech/playground-cli/main/install.sh | VERSION=dev/feat/signer-prompt-and-decentralize-sync bash

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Pass · ✅ PASS

Tag: e2e-ci-pr · Branch: feat/signer-prompt-and-decentralize-sync · Commit: eedee98 · Run logs

Cell Result Time
pr-mod ✅ PASS 1m27s
pr-deploy-frontend ✅ PASS 8m13s
pr-deploy-cdm ✅ PASS 4m02s
pr-preflight ✅ PASS 2m49s
pr-install ✅ PASS 0m45s
pr-deploy-foundry ✅ PASS 0m49s
pr-login-session ✅ PASS 1m51s
${{ matrix.cell }} ⏭️ SKIP 0m00s
${{ matrix.cell }} ⏭️ SKIP 0m00s

Sentry traces: view spans for this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant