fix(deploy): show mobile signer disabled (not hidden) when logged out#379
Merged
Conversation
When `playground deploy` runs without a logged-in session, the signer picker now renders the phone signer greyed out and unselectable instead of omitting it, so users can see the option exists. The cursor skips disabled options and defaults to the dev signer. The "mobile signing unavailable" notice moved below the options. Adds `disabled` support to the shared `Select` component, with the cursor-navigation helpers lifted into `selectNav.ts` and unit-tested.
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
playground deployruns without a logged-in mobile session, the signer picker previously hid the phone option and showed only the dev signer. This makes the feature less discoverable and the warning placement awkward.Two UX fixes:
requires \playground login` first`. The cursor skips it and defaults to the dev signer.How
disabled?: booleanto the sharedSelectcomponent'sSelectOption. Disabled options render dimmed, the initial cursor skips them, arrow navigation skips them in both directions, and Enter is guarded against confirming one.firstEnabledIndex/nextEnabledIndex) are lifted into a siblingselectNav.ts(per the repo convention of keeping pure logic out of.tsx) and unit-tested directly.deploySignerOptions(hasSession)now always returns both options, with the phone optiondisabledwhen there is no session.prompt-signercallouts inDeployScreento sit below the options.Notes
playground decentralizeintentionally keeps its phone option selectable-but-errors-on-select (established UX); a cross-reference comment documents the divergence.format:check,lint:license,typecheck,test— 937 tests).Test plan
selectNav.test.ts: covers disabled-start skip, wrap-around, all-disabled fallback, single-option, mid/tail-disabled in both directions, and the deploy logged-out case (cursor never lands on the disabled phone option).signerNotice.test.ts: updated to assert the phone option is shown disabled (not hidden) when logged out.