fix(mod): hide the setup.sh step when an app has none#381
Merged
Conversation
Apps without a setup.sh are the common case, but the absent-script path threw a StepWarning that StepRunner rendered as a yellow warning row, which alarmed users. Add a silent-skip mechanism to StepRunner (isSilentSkip flag, mirroring the existing isWarning/haltAsWarning duck-typing) that removes the step's row entirely while preserving ok and continuing execution. SetupScreen now throws SilentSkip when there is no setup.sh; setupRan stays false so the generic "Next steps" footer still prints.
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users run
playground modon an app with nosetup.sh, the "run setup.sh" step threw aStepWarning("no setup.sh found"), whichStepRunnerrendered as a yellow ⚠ warning row. Apps without a setup script are the common case, so this looked like something had gone wrong and alarmed users.Fix
StepRunner: added a silent-skip mechanism. A step that throws an error carryingisSilentSkip = trueis markedskipped, execution continues,okis preserved, and the row is filtered out of the rendered list entirely (nothing shows). This mirrors the existing duck-typedisWarning/haltAsWarningflags.SetupScreen: replaced the now-unusedStepWarningwith aSilentSkipclass, thrown whensetup.shis absent.setupRanstill staysfalseon this path, so the generic "Next steps" footer prints exactly as before — only the scary warning row is gone.Verification
All four CI checks pass locally:
pnpm format:check,pnpm lint:license,pnpm typecheck,pnpm test(84 files, 942 tests).🤖 Generated with Claude Code