feat(mod): gate tutorial-prompt nudge on the playground-tutorial.dot app#384
Merged
Conversation
The post-mod "Next steps" block now shows the (prompt: "start tutorial") nudge in step 2 only when modding playground-tutorial.dot, instead of whenever a quest track was started. The hardcoded domain check lives in its own tutorialPromptHint module so it can be removed in one go.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ❌ FAILTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The post-mod Next steps block prints a step 2 of the form:
Previously the
(prompt: "start tutorial")bracket appeared whenever the user started a quest track. This PR hardcodes it to appear only when moddingplayground-tutorial.dot.How
src/commands/mod/tutorialPromptHint.tsholds the hardcodedplayground-tutorial.dotdomain and exportsshouldShowTutorialPrompt({ domain, startedTutorial })(returns true only for that domain;startedTutorialis accepted but ignored so the call site keeps threading it through).src/commands/mod/index.tsfeedseditWithClaudeStepfromshouldShowTutorialPrompt(...)instead ofstartedTutorial.tutorialPromptHint.test.ts.The hardcode is deliberately isolated so it can be reverted in one step: delete the module + test and pass
startedTutorialstraight toeditWithClaudeStep.Verification
pnpm typecheck,pnpm format:check,pnpm lint:license, and the mod tests all pass. Changeset included.