feat(login): remove username step from playground login#386
Merged
Conversation
Drop the playground-registry username feature from `playground login`: the flow no longer prompts users to claim a handle (the "Earn 25 XP" step) and no longer displays a username in the shared header breadcrumb. - Delete UsernamePrompt, usernameNotice, and the entire utils/username module (no remaining consumers once the prompt is gone). - LoginScreen: remove username state, handler, render block, and the Header username prop. Account-setup failure now lands on "setup complete (with errors)" by construction. - completion.ts: drop usernameComplete from the completion predicate. - Header/headerLayout: remove the username breadcrumb piece; subtitle is now the sole shrinkable piece. The shared header is otherwise intact. - Clean up dangling references in comments and CLAUDE.md invariants.
Contributor
E2E Test Pass · ❌ FAILTag:
❌ Failed tests (1)
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the playground-registry username feature from
playground login. The flow no longer prompts users to claim a handle (the "Earn 25 XP" step) and no longer displays a username in the shared header breadcrumb.Why
Product decision: usernames are being dropped entirely. Nothing username-related should appear in the
playground loginTUI or its setup steps.Changes
UsernamePrompt.tsx,usernameNotice.ts, and the entiresrc/utils/username.tsmodule (and their tests) — once the prompt is gone the module has zero remaining consumers.LoginScreen.tsx— remove theusernamestate, its handler, the<UsernamePrompt>render block, and theusernameprop on<Header>. Account-setup failure now lands on "setup complete (with errors)" by construction (the oldsetUsername(null)unblock is no longer needed).completion.ts— dropusernameCompletefrom the login-completion predicate.Header.tsx/headerLayout.ts— remove theusernamebreadcrumb piece and its truncation handling from the shared header;subtitleis now the sole shrinkable piece. The shared header used by every other command is otherwise unchanged.CLAUDE.mdinvariants that named the deleted module.Verification
pnpm format:check✅pnpm lint:license✅pnpm typecheck✅pnpm test✅ (84 files / 916 tests)A repo-wide grep confirms no
usernamereferences remain insrc/,e2e/, orCLAUDE.md. (CHANGELOG history, thecdm.jsoncontract ABI, and the unrelated Sentry-dashboard author field are intentionally left untouched.)