test(e2e): fix two stale CLI output expectations#403
Merged
Conversation
Both assertions drifted from current behavior: - mod clone: the template (paritytech/Rock-Paper-Scissors) setup.sh no longer prints "[setup] …"; its progress lines are now "==>"-prefixed (e.g. "==> Installing npm dependencies..."). Match the "==>" prefix so the check is robust to upstream wording. - build no-strategy: the contracts-only fixture has only foundry.toml and no package.json, so detect.ts now reports the more specific "No package.json found" guidance rather than the generic "No build strategy detected". Assert the message the fixture actually produces.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ❌ FAILTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two E2E assertions that drifted from current behavior and were failing independently of any feature work (red on
main, e.g. the #401 merge run).1.
mod.test.ts—dot mod — cloneThe template repo (
paritytech/Rock-Paper-Scissors) updated itssetup.sh: it no longer prints[setup] Rock Paper Scissors tutorial. Its progress lines are now==>-prefixed (e.g.==> Installing npm dependencies...).Now asserts the
==>prefix — robust to the upstream template tweaking its individual step messages, while still provingsetup.shran and produced output.2.
build.test.ts— no build strategyThe
contracts-onlyfixture has onlyfoundry.toml(nopackage.json).src/utils/build/detect.tschecks for a missingpackage.jsonbefore the generic no-strategy hint, so it emits the more specific, more helpful message:Now asserts
No package.json found(the message that fixture actually produces). Renamed the test to "exits non-zero when there's nothing to build" to match.Why these are correct (not guesses)
==>output was verified against the livesetup.shon the template repo's default branch.No package.json foundmessage was verified againstsrc/utils/build/detect.tsand thecontracts-onlyfixture (onlyfoundry.toml, nopackage.json). The unit testsrc/utils/build/detect.test.tsalready asserts both branches.Notes