chore(funder): source dedicated funder seed from env secret#410
Merged
Conversation
The dedicated testnet funder seed was hardcoded in funder.ts, shipping in every published binary. Read it from the MASTER_FUNDER_SEED environment variable instead (CI injects it from the repository secret of the same name); when unset, the funder chain degrades to Alice-only. The chain is exercised only by the E2E suite and operator tooling, so no end-user command is affected. Also reorder the chain so the dedicated funder is primary and public Alice is the fallback — draw down our own controlled account first rather than the shared dev account others drain unpredictably. - funder.ts: derive dedicated funder from MASTER_FUNDER_SEED?.trim() at //0; drop the literal mnemonic; dedicated entry leads FUNDER_CHAIN - check-funder-balance.ts: exit 2 with a clear message when the seed is unset - CI: inject MASTER_FUNDER_SEED from the secret in the e2e + balance-check workflows - docs/e2e-bootstrap.md: MASTER_FUNDER_SEED is now actually consumed (was documented but unwired) - add funder.test.ts; update funding.test.ts for the new order
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ❌ FAILTag:
Sentry traces: view spans for this run |
…rder Follow-up to the env-secret funder change: - funder.ts: derive the dedicated funder at the bare root (empty derivation path) instead of //0, so the funded account matches the signing path; replace the address cast with a real null narrow in FUNDER_CHAIN - funder.test.ts: pin the derivation path with a frozen bare-root vector so a path regression fails loudly - e2e/e2e-release/e2e-post-release workflows: reword comments to describe the dedicated funder as primary and Alice as the fallback (matches the new order) - docs/e2e-bootstrap.md + changeset: reflect the bare-root primary funder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedicated testnet funder seed was hardcoded in funder.ts, shipping in every published binary. Read it from the MASTER_FUNDER_SEED environment variable instead (CI injects it from the repository secret of the same name); when unset, the funder chain degrades to Alice-only. The chain is exercised only by the E2E suite and operator tooling, so no end-user command is affected.
Also reorder the chain so the dedicated funder is primary and public Alice is the fallback — draw down our own controlled account first rather than the shared dev account others drain unpredictably.