Switch active testnet to Summit + fix jsxDEV compile crash#421
Merged
Conversation
Flip ACTIVE_TESTNET_ENV to "summit". This single constant threads through DEFAULT_ENV, the legacy testnet alias, token symbol (SUM), descriptor/endpoint selection, and the CDM meta-registry resolution (w3s). The config.test.ts divergence guard + non-empty-registry guard gate the flip and pass.
The compiled binary crashed on every UI-rendering command with "jsx_dev_runtime.jsxDEV is not a function". bun 1.3's bundler emits the development JSX automatic-runtime (jsxDEV) unconditionally, but --define process.env.NODE_ENV='"production"' flips React's inlined jsx-dev-runtime onto its production branch, which never assigns jsxDEV -> undefined -> crash at first Ink render. Shipped in v0.43.5/v0.43.6. Remove the define from all bun build --compile invocations (build, cli:install, and the three release workflows). Document the tripwire in CLAUDE.md (bun issue #23959, fix pending in bun PR #31651); restore the define once that lands. --version/--help were unaffected.
Contributor
E2E Test Pass · ❌ FAILTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes, each with its own changeset:
1. Switch active testnet to Web3 Summit (
minor)Flips
ACTIVE_TESTNET_ENVto"summit"insrc/config.ts— the single constant that threads throughDEFAULT_ENV, the legacytestnetalias, the token symbol (SUM), descriptor/endpoint selection, and the CDM meta-registry resolution (w3s).config.test.tsdivergence guard (summit endpoints must match polkadot-app-deploy's bundledenvironments.json) and the non-empty-registry guard both pass.0x49091Eb6…) is not stored in the repo — it resolves live at runtime from thew3sCDM meta-registry (0xa5747e60…, shipped in@parity/cdm-env@2.0.6). Verified live against summit Asset Hub.@parity/polkadot-app-deploy@0.11.0(our current pin) already ships the full summit env (endpoints + DotNS contracts), all confirmed on-chain.2. Fix jsxDEV compile crash (
patch)Every UI-rendering command crashed with
jsx_dev_runtime.jsxDEV is not a function. bun 1.3's bundler emits the development JSX automatic-runtime (jsxDEV) unconditionally, but--define process.env.NODE_ENV='"production"'flips React's inlinedjsx-dev-runtimeonto its production branch, which never assignsjsxDEV→ undefined → crash at first Ink render. This shipped in v0.43.5/v0.43.6.bun build --compileinvocations (build,cli:install, and the three release workflows).--version/--helpwere unaffected (they don't render Ink).Verification
pnpm typecheck,pnpm test(1005/1005),pnpm format:check,pnpm lint:license— all green.· summit, confirming both changes together).Follow-ups (not in this PR)
paseo_*descriptors (it is now env-gated).