Skip to content

Fix contract install registry selection#424

Merged
charlesHetterich merged 1 commit into
mainfrom
fix/contract-install-registry-env
Jun 18, 2026
Merged

Fix contract install registry selection#424
charlesHetterich merged 1 commit into
mainfrom
fix/contract-install-registry-env

Conversation

@charlesHetterich

Copy link
Copy Markdown
Collaborator

Summary

  • prefer the active Playground/CDM environment registry during playground contract install instead of stale cdm.json registry snapshots
  • keep cdm.json refreshed from cdm i -n w3s, pointing at the w3s meta-registry and live @w3s/playground-registry
  • add a regression test for stale cdm.json.registry during install target resolution

Verification

  • pnpm test src/commands/contract.test.ts
  • pnpm format:check
  • pnpm lint:license
  • pnpm typecheck
  • pnpm exec tsc --noEmit 2>&1 | grep -c "error TS" || true -> 0
  • pnpm test

@charlesHetterich charlesHetterich merged commit 688c6d9 into main Jun 18, 2026
16 of 20 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Dev build ready — try this branch:

curl -fsSL https://raw.githubusercontent.com/paritytech/playground-cli/main/install.sh | VERSION=dev/fix/contract-install-registry-env bash

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Pass · ❌ FAIL

Tag: e2e-ci-pr · Branch: fix/contract-install-registry-env · Commit: e29ec0c · Run logs

Cell Result Time
pr-deploy-foundry ✅ PASS 0m53s
pr-deploy-frontend ❌ FAIL 3m00s
pr-login-session ❌ FAIL 4m21s
pr-mod ❌ FAIL 2m35s
pr-deploy-cdm ✅ PASS 3m36s
pr-install ✅ PASS 0m59s
pr-preflight ❌ FAIL 2m41s
${{ matrix.cell }} ⏭️ SKIP 0m-1s
${{ matrix.cell }} ⏭️ SKIP 0m-1s
❌ Failed tests (3)
  • e2e/cli/deploy.test.ts › dot deploy --playground — full pipeline (requires Paseo + IPFS) > frontend-only deploy completes end-to-end
    expected '\n ╭────────────────────────────────…' to contain 'Deploy complete'
  • e2e/cli/deploy.test.ts › dot deploy --playground — full pipeline (requires Paseo + IPFS) > re-deploy same domain succeeds for same owner
    expected '\n ╭────────────────────────────────…' to contain 'Deploy complete'
  • e2e/cli/deploy.test.ts › dot deploy --playground — full pipeline (requires Paseo + IPFS) > domain taken by another account shows unavailable
    bob deploy unexpectedly succeeded: ╭────────────────────────────────────────────────────────────────────────────╮ │ Join the competition first │ │ Playground commands are for builders who've joined the competition, so you │ │ need to be signed in first. │ │ │ │ Run playground login and scan the QR code with your Polkadot mobile app, │ │ then become a builder and join the competition at playground.dot in your │ │ desktop app. │ ╰────────────────────────────────────────────────────────────────────────────╯ : expected +0 not to be +0 // Object.is equality

Sentry traces: view spans for this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant