ci: E2E suite Phase 1 — reporting + tagging#82
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the E2E suite redesign. Today's 27 E2E tests are unchanged — better-instrumented around. Spec:
docs-internal/2026-05-02-e2e-test-suite-design.md.What changed
E2E Reportjob posts a sticky PR comment with a per-cell summary table, failures detail block, and a Sentry traces link. Marker<!-- e2e-pr-report -->ensures the comment updates in place across pushes (verified during PR development — count stays at 1).nick-fields/retry@v3wraps the test invocation (max 2 attempts, 30s wait, 25-min per-attempt budget). Job timeout raised to 55 min so the retry budget can actually fit. Catches Paseo testnet flakes.DOT_TAG=e2e-ci-{pr|nightly|dispatch}propagated to the test run; CLI's existingcli.tagroot-span attribute (src/telemetry-config.ts:191) picks it up automatically.e2e-reports/junit.xml) + forensicdot-runs.loguploaded as workflow artefacts (7-day retention).src/index.test.ts— source-level guard against the documented Bun SEA stdin warm-up regression. Negative-lookbehind regex distinguishes the live call atsrc/index.ts:87from a//line comment that mentions it.simulate_failureworkflow_dispatch input was added, fired once to produce real issue Nightly E2E failure: 2026-05-02 #83 (closed), then removed in a separate commit so the verification path doesn't ship.Out of scope (future phases)
max-parallel: 1on publish cells (Phase 4)release: prereleasedtrigger (Phase 7)mainhas no protection rule at all; flipping to gating is a separate post-Phase-4 decision (see spec §7f for the one-shotgh apisnippet)Phase 1 + 2 fold note
The spec listed
DOT_TAGpropagation + Sentry traces link as Phase 2; this PR folds them into Phase 1 because the Sentry link is useless until tags are set, and both touch the same workflow file in tightly-coupled ways.Test plan
pnpm test— all unit tests pass (439, including newsrc/index.test.ts)pnpm exec vitest run e2e/cli/install.test.ts— JUnit XML produced,dot-runs.logpopulatedsimulate_failuredispatch path opened real issue Nightly E2E failure: 2026-05-02 #83 (closed); scaffolding removed inb106f66if: always()on report job correctly renders even whentestcancels (verified — see runs 25260814880 and 25260866303 where test was cancelled by concurrency but report succeeded)Related
docs-internal/2026-05-02-e2e-test-suite-design.md(Phase 1 of 8)docs-internal/2026-05-02-e2e-phase-1-plan.mddocs-internal/e2e-testing-spec.md§M1–M9