Skip to content

ci(e2e): Phase 5c — nightly-deploy-multi + parametrize contract-deploy tests#90

Merged
EnderOfWorlds007 merged 1 commit into
mainfrom
ci/e2e-phase-5c-multi-contract
May 3, 2026
Merged

ci(e2e): Phase 5c — nightly-deploy-multi + parametrize contract-deploy tests#90
EnderOfWorlds007 merged 1 commit into
mainfrom
ci/e2e-phase-5c-multi-contract

Conversation

@EnderOfWorlds007

Copy link
Copy Markdown
Collaborator

Phase 5c of the E2E redesign — multi-contract publish path + test parametrization.

Summary

  • New nightly-deploy-multi cell exercises the multi-contract --contracts batch publish path (TokenA.sol + TokenB.sol → e2e-cli-multi.dot)
  • Refactored the 3 near-identical contract-deploy tests (foundry, hardhat, multi) into a shared runContractDeployTest helper — net line reduction of ~40 LOC of repeated boilerplate
  • The CDM describe.skip block stays as-is pending its fixture upgrade (Phase 5f)
  • note and manualToolchain fields were considered and dropped per the simplify self-review: neither would be consumed inside the helper body

Test plan

  • Pattern counts verified locally: foundry=1, hardhat=1, multi=1, full pipeline=3
  • YAML parses clean (python3 -c "import yaml; yaml.safe_load(...)")
  • pnpm exec tsc --noEmit clean
  • pnpm format:check clean
  • pnpm test — 445 unit tests pass

Out of scope (subsequent sub-PRs)

  • Phase 5d: nightly-rejections-full (constructor-args new test)
  • Phase 5e: nightly-deploy-modable (--modable + GH repo)
  • Phase 5f: rust-cdm fixture upgrade + re-add pr-deploy-cdm
  • Phase 6: chaos cells
  • Phase 7: published-binary surface

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Dev build ready — try this branch:

curl -fsSL https://raw.githubusercontent.com/paritytech/playground-cli/main/install.sh | VERSION=dev/ci/e2e-phase-5c-multi-contract bash

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

E2E Test Pass · ✅ PASS

Tag: e2e-ci-pr · Branch: ci/e2e-phase-5c-multi-contract · Commit: 18e6e9d · Run logs

Cell Result Time
pr-deploy-frontend ✅ PASS 9m54s
pr-mod ✅ PASS 1m20s
pr-install ✅ PASS 0m33s
pr-init-session ✅ PASS 1m23s
pr-deploy-foundry ✅ PASS 1m40s
pr-preflight ✅ PASS 1m57s
${{ matrix.cell }} ⏭️ SKIP 0m00s
${{ matrix.cell }} ⏭️ SKIP 0m00s

Sentry traces: view spans for this run

@EnderOfWorlds007 EnderOfWorlds007 merged commit 3751335 into main May 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant