ci(e2e): Phase 5c — nightly-deploy-multi + parametrize contract-deploy tests#90
Merged
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5c of the E2E redesign — multi-contract publish path + test parametrization.
Summary
nightly-deploy-multicell exercises the multi-contract--contractsbatch publish path (TokenA.sol + TokenB.sol →e2e-cli-multi.dot)runContractDeployTesthelper — net line reduction of ~40 LOC of repeated boilerplatedescribe.skipblock stays as-is pending its fixture upgrade (Phase 5f)noteandmanualToolchainfields were considered and dropped per the simplify self-review: neither would be consumed inside the helper bodyTest plan
python3 -c "import yaml; yaml.safe_load(...)")pnpm exec tsc --noEmitcleanpnpm format:checkcleanpnpm test— 445 unit tests passOut of scope (subsequent sub-PRs)