feat(config): DOT_BULLETIN_RPC override + chaos-rpc cell (Phase 6 S18)#95
Merged
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
2 tasks
3fabd39 to
0b735fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 S18 — RPC failover chaos test.
Summary
DOT_BULLETIN_RPCenv var overrides the primary Bulletin RPC ingetChainConfig(), keeping the built-in URL asbulletinRpcFallbacks[0].bulletin-deploy'sdeploy()already builds[userRpc, DEFAULT]at runtime (verified in bundled JS), sostorage.tsgets failover for free.playground.ts's dedicated metadata-upload client now uses[cfg.bulletinRpc, ...cfg.bulletinRpcFallbacks]to get the same failover.nightly-chaos-rpccell intest-nightly-publishsetsDOT_BULLETIN_RPC=ws://127.0.0.1:1/and asserts the deploy still completes via fallback.chaosDeployArgs()helper factors out duplicated CLI args from the SIGINT test.Stacked on
Key finding
DeployOptions.rpcis typed asstringonly, but bulletin-deploy's runtime builds a[userRpc, DEFAULT]endpoint list internally (chunk-A2J6R5PD.js line 679) and passes it togetWsProvider(BULLETIN_ENDPOINTS, ...). The.d.tsunderdescribes the actual failover behavior.