Skip to content

Snowbridge: Set default asset claimer to local network#11919

Merged
acatangiu merged 11 commits into
paritytech:masterfrom
claravanstaden:set-bridge-owner-claimer-network
May 8, 2026
Merged

Snowbridge: Set default asset claimer to local network#11919
acatangiu merged 11 commits into
paritytech:masterfrom
claravanstaden:set-bridge-owner-claimer-network

Conversation

@claravanstaden
Copy link
Copy Markdown
Contributor

The inbound-queue v2 message converter falls back to the Snowbridge sovereign account on AssetHub as the asset claimer when no explicit claimer is supplied. Previously this fallback used AccountId32 { network: None, .. }, which did not match the location AssetHub's signed-origin converter produces (it sets network: Some(LocalNetwork)). The trap-key hash stored on AssetsTrapped therefore could not be matched by a signed polkadotXcm.claim_assets call, making default-claimer trapped funds effectively unrecoverable without a runtime upgrade.

This PR sets network: Some(LocalNetwork::get()) on the fallback claimer so its Location agrees with what SignedToAccountId32<_, _, LocalNetwork> yields on AssetHub, and adds a test covering the no-claimer-supplied path.

@claravanstaden
Copy link
Copy Markdown
Contributor Author

/cmd label T15-Bridges A4-backport-stable2603

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk Bot added A4-backport-stable2603 Pull request must be backported to the stable2603 release branch T15-bridges This PR/Issue is related to bridges. labels Apr 28, 2026
@claravanstaden claravanstaden marked this pull request as ready for review May 4, 2026 09:40
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team May 4, 2026 09:41
@acatangiu acatangiu added the A4-backport-unstable2604 Pull request must be backported to the unstable2604 release branch label May 5, 2026
Comment thread prdoc/pr_11919.prdoc
not match the location AssetHub's signed-origin converter produces (it sets
`network: Some(LocalNetwork)`). The trap-key hash stored on `AssetsTrapped`
therefore could not be matched by a signed `polkadotXcm.claim_assets` call,
making default-claimer trapped funds effectively unrecoverable without a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claravanstaden Do we have any trapped funds in Polkadot? If so, do we need some migration?

@acatangiu acatangiu enabled auto-merge May 7, 2026 11:27
auto-merge was automatically disabled May 7, 2026 12:31

Head branch was pushed to by a user without write access

@acatangiu acatangiu added this pull request to the merge queue May 8, 2026
Merged via the queue into paritytech:master with commit 2b5a0e1 May 8, 2026
267 of 269 checks passed
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2603:

@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for unstable2604:

acatangiu pushed a commit that referenced this pull request May 13, 2026
Backport #11919 into `stable2603` from claravanstaden.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev pushed a commit that referenced this pull request May 15, 2026
Backport #11919 into `unstable2604` from claravanstaden.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2603 Pull request must be backported to the stable2603 release branch A4-backport-unstable2604 Pull request must be backported to the unstable2604 release branch T15-bridges This PR/Issue is related to bridges.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants