From c9fb6c97b0cbdbe541812a7547463482a2f7b494 Mon Sep 17 00:00:00 2001 From: elle-j Date: Mon, 29 Jun 2026 09:39:30 +0200 Subject: [PATCH 1/8] Update revive-differential-tests ref and add newyork to workflow. --- .github/workflows/differential-tests.yml | 11 +++++++---- revive-differential-tests | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/differential-tests.yml b/.github/workflows/differential-tests.yml index 8e11097a..ef3f1289 100644 --- a/.github/workflows/differential-tests.yml +++ b/.github/workflows/differential-tests.yml @@ -5,8 +5,10 @@ on: env: IS_PUSH_TO_MAIN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} - # The compiler modes to use for compilation by retester. - MODES: "Y M0 S+, Y M3 S+, Y Mz S+" + # The exact compiler modes to use for compiling and comparing hashes by retester. + COMPILE_MODES: "Y M0 S+, Y M3 S+, Y Mz S+, NY Mz S+" + # The compiler modes allowed to run during e2e test execution by retester. + E2E_ALLOWED_MODES: "Y, NY Mz S+, NY Mz S-" SOLC_VERSION: "0.8.35" jobs: @@ -97,7 +99,7 @@ jobs: revive-differential-tests-path: revive/revive-differential-tests resolc-path: resolc-bin/resolc-${{ matrix.target }}${{ runner.os == 'Windows' && '.exe' || '' }} solc-version: ${{ env.SOLC_VERSION }} - modes: ${{ env.MODES }} + modes: ${{ env.COMPILE_MODES }} upload-artifact-name: compilation-report-${{ matrix.platform }} - name: Export Bytecode Hashes @@ -128,7 +130,7 @@ jobs: hashes-macos-arm64, ${{ env.IS_PUSH_TO_MAIN == 'true' && 'hashes-macos-x86_64,' || '' }} hashes-windows-x86_64 - modes: ${{ env.MODES }} + modes: ${{ env.COMPILE_MODES }} upload-artifact-name: hash-comparison-result run-e2e-tests: @@ -200,6 +202,7 @@ jobs: platform: revive-dev-node-polkavm-resolc resolc-path: ./resolc-bin/resolc-x86_64-unknown-linux-musl solc-version: ${{ env.SOLC_VERSION }} + allowed-modes: ${{ env.E2E_ALLOWED_MODES }} expectations-file-path: ./revive/.github/assets/revive-dev-node-polkavm-resolc.json # Use a sane value which is fast enough to make the tests run fast but not too # fast that it overwhelms the node. diff --git a/revive-differential-tests b/revive-differential-tests index 70e8a92f..6b3b6865 160000 --- a/revive-differential-tests +++ b/revive-differential-tests @@ -1 +1 @@ -Subproject commit 70e8a92f95bb73b6b2aa244f1bba46e0501e34f1 +Subproject commit 6b3b6865b863ca635102658392d8b67cd67e05e7 From 745ed937214e7a30bc8a1951f584043b09f0c01e Mon Sep 17 00:00:00 2001 From: elle-j Date: Mon, 29 Jun 2026 10:59:47 +0200 Subject: [PATCH 2/8] Temporarily test more newyork mode combinations. --- .github/workflows/differential-tests.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/differential-tests.yml b/.github/workflows/differential-tests.yml index ef3f1289..4bc8ad05 100644 --- a/.github/workflows/differential-tests.yml +++ b/.github/workflows/differential-tests.yml @@ -6,9 +6,10 @@ on: env: IS_PUSH_TO_MAIN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} # The exact compiler modes to use for compiling and comparing hashes by retester. - COMPILE_MODES: "Y M0 S+, Y M3 S+, Y Mz S+, NY Mz S+" + COMPILE_MODES: "NY M0 S+, NY M3 S+, NY Mz S+, NY M0 S-, NY M3 S-, NY Mz S-" # The compiler modes allowed to run during e2e test execution by retester. - E2E_ALLOWED_MODES: "Y, NY Mz S+, NY Mz S-" + # E.g. this can be updated to allow only `"Y, NY Mz S+"` (all Yul modes + newyork with -Oz and solc optimizer enabled). + E2E_ALLOWED_MODES: "Y, NY" SOLC_VERSION: "0.8.35" jobs: From dadca3a511c30bff2668fceb0311e8f408973a72 Mon Sep 17 00:00:00 2001 From: elle-j Date: Mon, 29 Jun 2026 23:53:48 +0200 Subject: [PATCH 3/8] Use limited set of `NY` for compile-only. --- .github/workflows/differential-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/differential-tests.yml b/.github/workflows/differential-tests.yml index 4bc8ad05..addd2b63 100644 --- a/.github/workflows/differential-tests.yml +++ b/.github/workflows/differential-tests.yml @@ -6,7 +6,7 @@ on: env: IS_PUSH_TO_MAIN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} # The exact compiler modes to use for compiling and comparing hashes by retester. - COMPILE_MODES: "NY M0 S+, NY M3 S+, NY Mz S+, NY M0 S-, NY M3 S-, NY Mz S-" + COMPILE_MODES: "Y M0 S+, Y M3 S+, Y Mz S+, NY M3 S+, NY Mz S+" # The compiler modes allowed to run during e2e test execution by retester. # E.g. this can be updated to allow only `"Y, NY Mz S+"` (all Yul modes + newyork with -Oz and solc optimizer enabled). E2E_ALLOWED_MODES: "Y, NY" @@ -204,6 +204,7 @@ jobs: resolc-path: ./resolc-bin/resolc-x86_64-unknown-linux-musl solc-version: ${{ env.SOLC_VERSION }} allowed-modes: ${{ env.E2E_ALLOWED_MODES }} + use-compilation-caches: false expectations-file-path: ./revive/.github/assets/revive-dev-node-polkavm-resolc.json # Use a sane value which is fast enough to make the tests run fast but not too # fast that it overwhelms the node. From 6aebf24770fd5bf9316ad8ad7081285319559251 Mon Sep 17 00:00:00 2001 From: elle-j Date: Tue, 30 Jun 2026 00:39:52 +0200 Subject: [PATCH 4/8] Update revive-differential-tests ref. --- revive-differential-tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/revive-differential-tests b/revive-differential-tests index 6b3b6865..38c9fa13 160000 --- a/revive-differential-tests +++ b/revive-differential-tests @@ -1 +1 @@ -Subproject commit 6b3b6865b863ca635102658392d8b67cd67e05e7 +Subproject commit 38c9fa13cc317d35858a2a2981a0d49a2fc60602 From c7a893644675f065043be40b7155505750752991 Mon Sep 17 00:00:00 2001 From: elle-j Date: Tue, 30 Jun 2026 18:40:02 +0200 Subject: [PATCH 5/8] Update revive-differential-tests ref. --- revive-differential-tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/revive-differential-tests b/revive-differential-tests index 38c9fa13..db19f154 160000 --- a/revive-differential-tests +++ b/revive-differential-tests @@ -1 +1 @@ -Subproject commit 38c9fa13cc317d35858a2a2981a0d49a2fc60602 +Subproject commit db19f15485e48892b242dbbb6fba7fb1ba00a090 From 7c9cec6f0ba9be0ca20dddc932b4a4f83de5e83a Mon Sep 17 00:00:00 2001 From: elle-j Date: Wed, 1 Jul 2026 18:06:17 +0200 Subject: [PATCH 6/8] Exercise more modes on `main` for bytecode comparison. --- .github/workflows/differential-tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/differential-tests.yml b/.github/workflows/differential-tests.yml index addd2b63..39142149 100644 --- a/.github/workflows/differential-tests.yml +++ b/.github/workflows/differential-tests.yml @@ -6,7 +6,11 @@ on: env: IS_PUSH_TO_MAIN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} # The exact compiler modes to use for compiling and comparing hashes by retester. - COMPILE_MODES: "Y M0 S+, Y M3 S+, Y Mz S+, NY M3 S+, NY Mz S+" + # Runs triggered by pushes to main exercise more modes. + COMPILE_MODES: >- + ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') + && 'Y M0 S+, Y M3 S+, Y Mz S+, NY M0 S+, NY M3 S+, NY Mz S+' + || 'Y M0 S+, Y M3 S+, Y Mz S+, NY Mz S+' }} # The compiler modes allowed to run during e2e test execution by retester. # E.g. this can be updated to allow only `"Y, NY Mz S+"` (all Yul modes + newyork with -Oz and solc optimizer enabled). E2E_ALLOWED_MODES: "Y, NY" From d8f3c99cbe32802a3d79f510eae1068d99810ba1 Mon Sep 17 00:00:00 2001 From: elle-j Date: Wed, 1 Jul 2026 18:07:16 +0200 Subject: [PATCH 7/8] Update revive-differential-tests ref. --- revive-differential-tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/revive-differential-tests b/revive-differential-tests index db19f154..1366af7a 160000 --- a/revive-differential-tests +++ b/revive-differential-tests @@ -1 +1 @@ -Subproject commit db19f15485e48892b242dbbb6fba7fb1ba00a090 +Subproject commit 1366af7a0a1e096db80176e3d52bea4c208120ba From aebe0ae392ab0d229ded64a56de4dfe96b3dc048 Mon Sep 17 00:00:00 2001 From: elle-j Date: Thu, 2 Jul 2026 10:10:59 +0200 Subject: [PATCH 8/8] Update revive-differential-tests ref. --- revive-differential-tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/revive-differential-tests b/revive-differential-tests index 1366af7a..f5d444da 160000 --- a/revive-differential-tests +++ b/revive-differential-tests @@ -1 +1 @@ -Subproject commit 1366af7a0a1e096db80176e3d52bea4c208120ba +Subproject commit f5d444dacfb474e55014a871a5f4f61679ba7f82