Skip to content

Extend differential tests with newyork optimizer #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elle-j merged 9 commits into from
Jul 2, 2026
Merged

Extend differential tests with newyork optimizer #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9fb6c9
Update revive-differential-tests ref and add newyork to workflow.
elle-j Jun 29, 2026
745ed93
Temporarily test more newyork mode combinations.
elle-j Jun 29, 2026
dadca3a
Use limited set of `NY` for compile-only.
elle-j Jun 29, 2026
6aebf24
Update revive-differential-tests ref.
elle-j Jun 29, 2026
c7a8936
Update revive-differential-tests ref.
elle-j Jun 30, 2026
7c9cec6
Exercise more modes on `main` for bytecode comparison.
elle-j Jul 1, 2026
d8f3c99
Update revive-differential-tests ref.
elle-j Jul 1, 2026
aebe0ae
Update revive-differential-tests ref.
elle-j Jul 2, 2026
271bc9f
Merge branch 'main' into lj/retester-newyork
elle-j Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/differential-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@ on:

env:
IS_PUSH_TO_MAIN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
# The compiler modes to use for compilation by retester.
MODES: "Y M0 S+, Y M3 S+, Y Mz S+"
# The exact compiler modes to use for compiling and comparing hashes by retester.
# Runs triggered by pushes to main exercise more modes.
Comment thread
elle-j marked this conversation as resolved.
COMPILE_MODES: >-
${{ (github.event_name == 'push' && github.ref == 'refs/heads/main')
&& 'Y M0 S+, Y M3 S+, Y Mz S+, NY M0 S+, NY M3 S+, NY Mz S+'
|| 'Y M0 S+, Y M3 S+, Y Mz S+, NY Mz S+' }}
# The compiler modes allowed to run during e2e test execution by retester.
# E.g. this can be updated to allow only `"Y, NY Mz S+"` (all Yul modes + newyork with -Oz and solc optimizer enabled).
E2E_ALLOWED_MODES: "Y, NY"
Comment thread
elle-j marked this conversation as resolved.
SOLC_VERSION: "0.8.35"

jobs:
Expand Down Expand Up @@ -97,7 +104,7 @@ jobs:
revive-differential-tests-path: revive/revive-differential-tests
resolc-path: resolc-bin/resolc-${{ matrix.target }}${{ runner.os == 'Windows' && '.exe' || '' }}
solc-version: ${{ env.SOLC_VERSION }}
modes: ${{ env.MODES }}
modes: ${{ env.COMPILE_MODES }}
upload-artifact-name: compilation-report-${{ matrix.platform }}

- name: Export Bytecode Hashes
Expand Down Expand Up @@ -128,7 +135,7 @@ jobs:
hashes-macos-arm64,
${{ env.IS_PUSH_TO_MAIN == 'true' && 'hashes-macos-x86_64,' || '' }}
hashes-windows-x86_64
modes: ${{ env.MODES }}
modes: ${{ env.COMPILE_MODES }}
upload-artifact-name: hash-comparison-result

run-e2e-tests:
Expand Down Expand Up @@ -200,6 +207,8 @@ jobs:
platform: revive-dev-node-polkavm-resolc
resolc-path: ./resolc-bin/resolc-x86_64-unknown-linux-musl
solc-version: ${{ env.SOLC_VERSION }}
allowed-modes: ${{ env.E2E_ALLOWED_MODES }}
use-compilation-caches: false
expectations-file-path: ./revive/.github/assets/revive-dev-node-polkavm-resolc.json
# Use a sane value which is fast enough to make the tests run fast but not too
# fast that it overwhelms the node.
Expand Down
2 changes: 1 addition & 1 deletion revive-differential-tests
Open in desktop
Submodule revive-differential-tests updated 126 files
Loading