fix: finish benchmarks migration and remove init.sh from benchmark folders (#1954)

Author: Imod7

.github/workflows/benchmark.yml

@@ -26,6 +26,16 @@ jobs:
           echo "Benchmarks for polkadot"
           mkdir -p artifacts
           yarn bench --log-level info --ws-url wss://rpc.polkadot.io
+          if [ ! -s benchmarks.txt ]; then
+            echo "::error::yarn bench produced empty benchmarks.txt"
+            exit 1
+          fi
+          if ! grep -q "Avg RequestTime(Latency)" benchmarks.txt; then
+            echo "::error::benchmarks.txt contains no latency results — wrk done() callback may not have fired"
+            echo "Contents of benchmarks.txt:"
+            cat benchmarks.txt
+            exit 1
+          fi
           mv benchmarks.txt artifacts/
 
       - name: upload artifacts
@@ -56,7 +66,19 @@ jobs:
           path: artifacts
 
       - name: Modify benches result for benchmark action
-        run: ./scripts/ci/benchmarks/generate_benchmark_result.sh artifacts/benchmarks.txt > artifacts/benchmarks.json
+        run: |
+          # Write to temp file first — only promote to benchmarks.json if it has entries
+          ./scripts/ci/benchmarks/generate_benchmark_result.sh artifacts/benchmarks.txt > artifacts/benchmarks_tmp.json
+          ENTRIES=$(python3 -c "import json; print(len(json.load(open('artifacts/benchmarks_tmp.json'))))")
+          if [ "$ENTRIES" -eq 0 ]; then
+            echo "::error::benchmarks.json has 0 entries after parsing"
+            echo "Contents of benchmarks.txt:"
+            cat artifacts/benchmarks.txt
+            rm -f artifacts/benchmarks_tmp.json
+            exit 1
+          fi
+          mv artifacts/benchmarks_tmp.json artifacts/benchmarks.json
+          echo "benchmarks.json contains $ENTRIES benchmark results"
 
       - name: Store benchmark result
         uses: benchmark-action/github-action-benchmark@a7bc2366eda11037936ea57d811a43b3418d3073 #1.21.0

benchmarks/accountsConvert/init.sh

@@ -14,8 +14,26 @@
 -- You should have received a copy of the GNU General Public License
 -- along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-local accountsConvert = {
-    '0xde1894014026720b9918b1b21b488af8a0d4f15953621233830946ec0b4d7b75/convert'
+-- Accounts convert endpoint benchmark script
+-- Tests the /accounts/{accountId}/convert endpoint for latency and throughput
+
+local util = require("util")
+
+local endpoints = {
+    '0xde1894014026720b9918b1b21b488af8a0d4f15953621233830946ec0b4d7b75/convert',
 }
 
-return accountsConvert
+util.print_endpoints(endpoints)
+
+local counter = 1
+
+request = function()
+    local endpoint = endpoints[counter]
+    counter = counter + 1
+    if counter > #endpoints then
+        counter = 1
+    end
+    return wrk.format("GET", util.prefix .. "/accounts/" .. endpoint)
+end
+
+done = util.done()

benchmarks/accountsValidate/init.sh

@@ -14,7 +14,12 @@
 -- You should have received a copy of the GNU General Public License
 -- along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-local accountsValidate = {
+-- Accounts validate endpoint benchmark script
+-- Tests the /accounts/{accountId}/validate endpoint for latency and throughput
+
+local util = require("util")
+
+local endpoints = {
     '15GADXLmZpfCDgVcPuLGCwLAWw3hV9UpwPHw9BJuZEkQREqB/validate',
     '148fP7zCq1JErXCy92PkNam4KZNcroG9zbbiPwMB1qehgeT4/validate',
     '121bKwxHucGnDavnkQymq2hW12hsQ3KvXR1zJwAWiafG3Lfx/validate',
@@ -25,7 +30,20 @@ local accountsValidate = {
     '0x002a39366f6620a6c2e2fed5990a3d419e6a19dd127fc7a50b515cf17e2dc5cc592312/validate', -- polkadot addr
     '0x02ce046d43fc4c0fb8b3b754028515e5020f5f1d8d620b4ef0f983c5df34b1952909e9/validate', -- kusama addr
     '0x086d6f646c6163612f6364707400000000000000000000000000000000000000008333/validate', -- karura addr
-    '0x2a39366f6620a6c2e2fed5990a3d419e6a19dd127fc7a50b515cf17e2dc5cc59/validate', -- Invalid addr
+    '0x2a39366f6620a6c2e2fed5990a3d419e6a19dd127fc7a50b515cf17e2dc5cc59/validate',       -- invalid addr
 }
 
-return accountsValidate
+util.print_endpoints(endpoints)
+
+local counter = 1
+
+request = function()
+    local endpoint = endpoints[counter]
+    counter = counter + 1
+    if counter > #endpoints then
+        counter = 1
+    end
+    return wrk.format("GET", util.prefix .. "/accounts/" .. endpoint)
+end
+
+done = util.done()