feat: add evmFormat option to blocks queries for revive pallet#1729
Merged
Conversation
filvecchiato
changed the title
andrew-ifrita
left a comment
andrew-ifrita
left a comment
Contributor
There was a problem hiding this comment.
In general it looks like. Just had some minor questions.
I doubt address types will change at all, but it may be worth changing useEvmFormat to something like addressFormat or similar just to future proof in case we add another at any point in the future.
andrew-ifrita
approved these changes
Aug 21, 2025
TarikGul
requested changes
Aug 27, 2025
TarikGul
left a comment
TarikGul
left a comment
Member
There was a problem hiding this comment.
Just a question, and a small nit.
TarikGul
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement an option to convert the data included in the emitted events from pallet-revive into evm format (for addresses). The default method returns the standard SS58 format, while using the query param
useEvmFormat=truewill return the data with evm formatted addresses.closes #1660