feat: Add accounts/{}/foreign-asset-balances#1834
Merged
Merged
Conversation
andrew-ifrita
force-pushed
the
feat/foreign-asset-balances
branch
from
c851e0d to
aa307b2
Compare
andrew-ifrita
commented
Nov 24, 2025
andrew-ifrita
commented
Nov 24, 2025
Inspired from Filippo's suggestion
filvecchiato
approved these changes
Nov 24, 2025
filvecchiato
left a comment
filvecchiato
left a comment
Contributor
There was a problem hiding this comment.
Looking nice! one minor nit about isFrozen
TarikGul
reviewed
Nov 24, 2025
TarikGul
reviewed
Nov 24, 2025
| * | ||
| * @param entries Foreign asset storage entries | ||
| */ | ||
| extractMultiLocationsFromAssetEntries(entries: [StorageKey<AnyTuple>, unknown][]): AnyJson[] { |
Member
There was a problem hiding this comment.
Suggested change
| extractMultiLocationsFromAssetEntries(entries: [StorageKey<AnyTuple>, unknown][]): AnyJson[] { | |
| extractMultiLocationsFromAssetEntries(entries: [[StorageKey<AnyTuple>, unknown][]](entries: [StorageKey<[StagingXcmV5Location]>, Option<PalletAssetsAssetDetails>][])): StagingXcmV5Location[] { |
Then you can access the storageKey via: storageKey.args[0], and you can return the actual type here as StagingXcmV5Location[]
TarikGul
reviewed
Nov 24, 2025
TarikGul
reviewed
Nov 24, 2025
TarikGul
requested changes
Nov 24, 2025
TarikGul
left a comment
TarikGul
left a comment
Member
There was a problem hiding this comment.
Overall, great PR. Just some typings need to be changed in order to clear up all the type castings and eslint ignores.
Member
|
Also docsv2/ needs to be updated with the new endpoint. |
Contributor
Author
Yeah good call. Added in 6833fe2 |
Using XcmVersionedLocation now.
andrew-ifrita
force-pushed
the
feat/foreign-asset-balances
branch
from
6bc9fb6 to
4b2f027
Compare
TarikGul
approved these changes
Nov 25, 2025
TarikGul
left a comment
TarikGul
left a comment
Member
There was a problem hiding this comment.
Changes going in look good so far! 🚀 Going to give this a check as to not block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidecar currently lacks a means to query the foreign asset balances for an account
Discussion
Should this be a separate endpoint?
Should this be seamlessly integrated with the
asset-balancescall instead?