Merge branch 'feat/create-transaction-refinement' into feat/scheduled-notifications

Author: johnthecat

CHANGELOG.md

@@ -1,3 +1,24 @@
+## 0.7.9 (2026-05-11)
+
+### 🚀 Features
+
+- **host-papp:** user attestation has moved off the Host and onto the paired Polkadot Mobile app. The Host no longer drives the attestation flow during sign-in — the mobile app handles it end-to-end as part of pairing.
+- **host-papp:** `UserSession` gains a `createTransaction(payload)` method. The Host can now delegate product-account transaction signing to the paired Polkadot Mobile app via the new `CreateTransactionRequest` / `CreateTransactionResponse` SSO message pair (legacy-account signing stays Host-local).
+- **product-sdk:** new top-level `accounts` singleton (`createAccountsProvider()` with the default sandbox transport) for products that don't need a custom transport.
+- **product-sdk:** export `ProductAccountId` and `LegacyAccount` types.
+
+### ⚠️ Breaking Changes
+
+- **host-api:** `host_create_transaction` no longer takes a separate `account_id` parameter — the account is now part of the payload as a typed `signer` field.
+- **host-api:** `TxPayloadV1.signer` is now required and typed (`ProductAccountId` or `AccountId`) instead of `Option<str>`.
+- **host-api:** dropped the `context` field from `TxPayloadV1` (runtime metadata, token symbol/decimals, best block height). The signer derives these from the chain.
+- **host-api:** removed the `VersionedTxPayload` envelope from `host_create_transaction*` — pass the payload directly.
+- **product-sdk:** `getProductAccountSigner` now returns a `PolkadotSigner` whose `signTx` routes through `host_create_transaction` and returns the full signed extrinsic; `signBytes` routes through `host_sign_raw`. Previously `signTx` called `host_sign_payload` and returned a detached signature via `getPolkadotSignerFromPjs`. Callers no longer need to assemble the extrinsic themselves.
+- **product-sdk:** the `Signer.createTransaction` payload shape changed to match the new `TxPayloadV1` (no `version`, no `context`, typed `signer`).
+- **product-sdk:** new runtime dependency `@polkadot-api/substrate-bindings@^0.20.2` (used by `getProductAccountSigner` to decode metadata locally and pick `txExtVersion`).
+
+  > No compatibility shim. `host_create_transaction` had no production consumers and `host_create_transaction_with_legacy_account` is only reachable via `product-sdk`, which is bumped in lockstep.
+
 ## 0.7.8 (2026-05-08)
 
 ### 🚀 Features

__tests__/hostApi/accounts.spec.ts

@@ -9,7 +9,7 @@ import {
   createTransport,
   toHex,
 } from '@novasamatech/host-api';
-import type { AccountConnectionStatus, ProductAccount } from '@novasamatech/host-api-wrapper';
+import type { AccountConnectionStatus, LegacyAccount, ProductAccount } from '@novasamatech/host-api-wrapper';
 import { createAccountsProvider } from '@novasamatech/host-api-wrapper';
 import type { ContainerHandlerOf } from '@novasamatech/host-container';
 import { createContainer } from '@novasamatech/host-container';
@@ -29,11 +29,15 @@ function setup() {
 }
 
 const mockPublicKey = new Uint8Array(32).fill(1);
-const mockAccount: ProductAccount = {
+const mockProductAccount: ProductAccount = {
   dotNsIdentifier: 'product.dot',
   derivationIndex: 0,
   publicKey: mockPublicKey,
 };
+const mockLegacyAccount: LegacyAccount = {
+  publicKey: mockPublicKey,
+  name: 'Test Account',
+};
 
 const mockRingLocation: CodecType<typeof RingLocation> = {
   genesisHash: toHex(new Uint8Array(32).fill(0x22)),
@@ -95,14 +99,13 @@ describe('Host API: Accounts', () => {
   describe('getProductAccount', () => {
     it('should return account on success', async () => {
       const { container, accountsProvider } = setup();
-      const expected = { publicKey: mockPublicKey };
 
-      container.handleAccountGet((_, { ok }) => ok(expected));
+      container.handleAccountGet((_, { ok }) => ok({ publicKey: mockPublicKey }));
 
       const result = await accountsProvider.getProductAccount('product.dot', 0);
 
       expect(result.isOk()).toBe(true);
-      expect(result._unsafeUnwrap()).toEqual(expected);
+      expect(result._unsafeUnwrap()).toEqual(mockProductAccount);
     });
 
     it('should pass dotNsIdentifier and derivationIndex to handler', async () => {
@@ -304,7 +307,7 @@ describe('Host API: Accounts', () => {
   describe('getProductAccountSigner', () => {
     it('should expose the correct public key', () => {
       const { accountsProvider } = setup();
-      const signer = accountsProvider.getProductAccountSigner(mockAccount);
+      const signer = accountsProvider.getProductAccountSigner(mockProductAccount);
 
       expect(signer.publicKey).toEqual(mockPublicKey);
     });
@@ -320,11 +323,11 @@ describe('Host API: Accounts', () => {
         return ok({ signature: toHex(signatureBytes), signedTransaction: undefined });
       });
 
-      const signer = accountsProvider.getProductAccountSigner(mockAccount);
+      const signer = accountsProvider.getProductAccountSigner(mockProductAccount);
       const result = await signer.signBytes(rawData);
 
       expect(capturedParams).toEqual({
-        account: [mockAccount.dotNsIdentifier, mockAccount.derivationIndex],
+        account: [mockProductAccount.dotNsIdentifier, mockProductAccount.derivationIndex],
         payload: { tag: 'Bytes', value: rawData },
       });
       expect(result).toEqual(signatureBytes);
@@ -336,7 +339,7 @@ describe('Host API: Accounts', () => {
 
       container.handleSignRaw((_, { err }) => err(error));
 
-      const signer = accountsProvider.getProductAccountSigner(mockAccount);
+      const signer = accountsProvider.getProductAccountSigner(mockProductAccount);
 
       await expect(signer.signBytes(new Uint8Array([1, 2, 3]))).rejects.toEqual(error);
     });
@@ -345,7 +348,7 @@ describe('Host API: Accounts', () => {
   describe('getLegacyAccountSigner', () => {
     it('should expose the correct public key', () => {
       const { accountsProvider } = setup();
-      const signer = accountsProvider.getLegacyAccountSigner(mockAccount);
+      const signer = accountsProvider.getLegacyAccountSigner(mockLegacyAccount);
 
       expect(signer.publicKey).toEqual(mockPublicKey);
     });
@@ -361,7 +364,7 @@ describe('Host API: Accounts', () => {
         return ok({ signature: toHex(signatureBytes), signedTransaction: undefined });
       });
 
-      const signer = accountsProvider.getLegacyAccountSigner(mockAccount);
+      const signer = accountsProvider.getLegacyAccountSigner(mockLegacyAccount);
       const result = await signer.signBytes(rawData);
 
       expect(capturedParams).toMatchObject({ payload: { tag: 'Bytes', value: rawData } });
@@ -374,7 +377,7 @@ describe('Host API: Accounts', () => {
 
       container.handleSignRawWithLegacyAccount((_, { err }) => err(error));
 
-      const signer = accountsProvider.getLegacyAccountSigner(mockAccount);
+      const signer = accountsProvider.getLegacyAccountSigner(mockLegacyAccount);
 
       await expect(signer.signBytes(new Uint8Array([1, 2, 3]))).rejects.toEqual(error);
     });

__tests__/hostApi/injectedWeb3Provider.spec.ts

@@ -108,12 +108,12 @@ describe('Host API: injected web3 provider', () => {
     const response = new Uint8Array([0, 0, 1, 1]);
     const payload = {
       version: 1 as const,
-      signer: 'test',
+      signer: AccountId().dec(new Uint8Array(32)),
       callData: '0x0002' as const,
       extensions: [
         {
-          id: 'test',
-          additionalSigned: '0x0000' as const,
+          id: 'CheckGenesis',
+          additionalSigned: toHex(new Uint8Array(32)),
           extra: '0x0000' as const,
         },
       ],
@@ -191,12 +191,12 @@ describe('Host API: injected web3 provider', () => {
 
     const payload = {
       version: 1 as const,
-      signer: 'test',
+      signer: AccountId().dec(new Uint8Array(32)),
       callData: '0x0002' as const,
       extensions: [
         {
-          id: 'test',
-          additionalSigned: '0x0000' as const,
+          id: 'CheckGenesis',
+          additionalSigned: toHex(new Uint8Array(32)),
           extra: '0x0000' as const,
         },
       ],

docs/design/host-api-protocol.md

@@ -147,13 +147,11 @@ fn host_account_create_proof(
 fn host_get_legacy_accounts() -> Result<Vec<LegacyAccount>, RequestCredentialsErr>;
 
 fn host_create_transaction(
-  accountId: ProductAccountId,
-  payload: VersionedTxPayload
+  payload: TxPayloadV1<ProductAccountId>
 ) -> Result<Vec<u8>, CreateTransactionErr>;
 
 fn host_create_transaction_with_legacy_account(
-  accountId: AccountId,
-  payload: VersionedTxPayload
+  payload: TxPayloadV1<AccountId>
 ) -> Result<Vec<u8>, CreateTransactionErr>;
 
 fn host_sign_raw_with_legacy_account(
@@ -765,14 +763,17 @@ fn host_get_legacy_accounts() -> Result<Vec<LegacyAccount>, RequestCredentialsEr
 
 #### Create Transaction
 
-Based on [https://github.com/polkadot-js/api/issues/6213](https://github.com/polkadot-js/api/issues/6213), but omitting the `version` field.\
-This format is capable of supporting both V4 and V5 extrinsics.
-There are two different methods for creating a transaction: `create_transaction` and `create_transaction_with_legacy_account`. `create_transaction` is bound to the Host API account model; `create_transaction_with_legacy_account`, on the other hand, can request signing with any legacy account, and the host should decide how to find or derive accounts for signing using the `signer` field as a reference.
+Derived from [https://github.com/polkadot-js/api/issues/6213](https://github.com/polkadot-js/api/issues/6213) but trimmed for an online-signer topology: the `version` field is omitted, and the `context` block (runtime metadata, token symbol/decimals, best block height) is dropped — the signer (Host or Account Holder) is online and derives those from the chain identified by `CheckGenesis` rather than trusting a product-supplied blob.
+
+The format is capable of supporting both V4 and V5 extrinsics.
+
+There are two methods for creating a transaction: `create_transaction` and `create_transaction_with_legacy_account`. Both take a `TxPayloadV1<Signer>` parametrized by the signer-identifier type — `ProductAccountId` for product accounts and `AccountId` for legacy accounts. The `signer` field is required and typed; there is no separate `account_id` parameter.
 
 ```rust
 enum CreateTransactionErr {
   FailedToDecode,
   Rejected,
+  // Unsupported payload version
   // Failed to infer missing extensions, some extension is unsupported, etc.
   NotSupported(str),
   PermissionDenied,
@@ -785,35 +786,24 @@ struct TxPayloadExtensionV1 {
   additional_signed: Vec<u8>
 }
 
-struct TxPayloadContext {
-  metadata: Vec<u8>,
-  token_symbol: str,
-  token_decimals: u32,
-  best_block_height: u32
-}
-
-struct TxPayloadV1 {
-  signer: Option<str>,
+struct TxPayloadV1<Signer> {
+  signer: Signer,
   call_data: Vec<u8>,
   extensions: Vec<TxPayloadExtensionV1>,
-  tx_ext_version: u8,
-  context: TxPayloadContext
-}
-
-enum VersionedTxPayload {
-  V1(TxPayloadV1)
+  tx_ext_version: u8
 }
 
 fn host_create_transaction(
-  account_id: ProductAccountId,
-  payload: VersionedTxPayload
+  payload: TxPayloadV1<ProductAccountId>
 ) -> Result<Vec<u8>, CreateTransactionErr>;
 
 fn host_create_transaction_with_legacy_account(
-  payload: VersionedTxPayload
+  payload: TxPayloadV1<AccountId>
 ) -> Result<Vec<u8>, CreateTransactionErr>;
 ```
 
+> Note: `TxPayloadV1<Signer>` is type-level shorthand for one concrete encoding per call site; the SCALE codec on the wire is not generic.
+
 #### Signing Raw
 
 Signing of raw bytes. The interface implementation is similar to `signRaw` from `injectedWeb3`, added for backward compatibility.