Skip to content

fix: expiry field is mandatory. #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
P1sar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: expiry field is mandatory. #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/hostApi/statementStore.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function createMockSignedStatement(topicSeed: number): SignedStatement {
signer: new Uint8Array(32).fill(2),
}),
decryptionKey: undefined,
expiry: undefined,
expiry: BigInt(Math.floor(Date.now() / 1000) + 7 * 24 * 60 * 60) << 32n,
channel: undefined,
topics: [createTopic(topicSeed)],
data: new Uint8Array([1, 2, 3]),
Expand All @@ -51,7 +51,7 @@ function createMockStatement(topicSeed: number): Statement {
return {
proof: undefined,
decryptionKey: undefined,
expiry: undefined,
expiry: BigInt(Math.floor(Date.now() / 1000) + 7 * 24 * 60 * 60) << 32n,
channel: undefined,
topics: [createTopic(topicSeed)],
data: new Uint8Array([1, 2, 3]),
Expand Down
4 changes: 2 additions & 2 deletions docs/design/host-api-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ enum StatementProof {
struct Statement {
proof: Option<StatementProof>,
decryption_key: Option<DecryptionKey>,
priority: Option<u32>,
expiry: u64,
channel: Option<Channel>,
topics: Vec<Topic>,
data: Option<Vec<u8>>
Expand All @@ -1089,7 +1089,7 @@ struct Statement {
struct SignedStatement {
proof: StatementProof,
decryption_key: Option<DecryptionKey>,
priority: Option<u32>,
expiry: u64,
channel: Option<Channel>,
topics: Vec<Topic>,
data: Option<Vec<u8>>
Expand Down
4 changes: 2 additions & 2 deletions packages/host-api/src/protocol/v1/statementStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const StatementProof = Enum({
export const Statement = Struct({
proof: Option(StatementProof),
decryptionKey: Option(DecryptionKey),
expiry: Option(u64),
expiry: u64,
channel: Option(Channel),
topics: Vector(Topic),
data: Option(Bytes()),
Expand All @@ -52,7 +52,7 @@ export const Statement = Struct({
export const SignedStatement = Struct({
proof: StatementProof,
decryptionKey: Option(DecryptionKey),
expiry: Option(u64),
expiry: u64,
channel: Option(Channel),
topics: Vector(Topic),
data: Option(Bytes()),
Expand Down