Skip to content

fix(host-papp): raise SSO request size limit#181

Merged
johnthecat merged 3 commits into
release/0.8from
fix/host-papp-sso-request-size
May 26, 2026
Merged

fix(host-papp): raise SSO request size limit#181
johnthecat merged 3 commits into
release/0.8from
fix/host-papp-sso-request-size

Conversation

@charlesHetterich

@charlesHetterich charlesHetterich commented May 25, 2026

Copy link
Copy Markdown

Summary

  • raise host-papp SSO request maxRequestSize to 254 KiB
  • keep the limit below the mobile 256 KiB statement cap
  • add coverage that createUserSession passes the larger cap to statement-store

Context

The statement-store default is 4 KiB. Larger tx signing requests currently fail host-side with "message too big" before the mobile app can sign them.

Testing

Local Node: v22.18.0

  • npm run build
  • npm run lint
  • npm run typecheck
  • npm test
  • npx vitest run packages/host-papp/tests/userSession.spec.ts
  • npx prettier --check packages/host-papp/src/sso/sessionManager/userSession.ts packages/host-papp/tests/userSession.spec.ts

@valentunn
valentunn requested a review from johnthecat May 25, 2026 20:11
// when the corresponding code path runs. If a future refactor drops an emit,
// the matching assertion below fails.
describe('createUserSession debug emits', () => {
it('configures the statement-store session for mobile-sized SSO requests', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this test it makes no sense

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, yeah sorry about that

@johnthecat
johnthecat changed the base branch from main to release/0.8 May 26, 2026 15:24
@johnthecat
johnthecat merged commit c5c628d into release/0.8 May 26, 2026
5 checks passed
@johnthecat
johnthecat deleted the fix/host-papp-sso-request-size branch June 11, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants