Skip to content

Revert "fix(host-api): tear down subscriptions on transport disposal" (#196)#201

Merged
cuteWarmFrog merged 1 commit into
mainfrom
revert-196-transport-dispose
Jun 4, 2026
Merged

Revert "fix(host-api): tear down subscriptions on transport disposal" (#196)#201
cuteWarmFrog merged 1 commit into
mainfrom
revert-196-transport-dispose

Conversation

@cuteWarmFrog

Copy link
Copy Markdown
Contributor

This reverts #196 (commit 055b4fe).

The change made the transport tear down all active producer subscriptions when it is destroyed, and silently drop emissions that arrive after disposal. Reverting restores the previous behavior:

  • Producer subscriptions are no longer automatically torn down on transport destruction — cleanup is again the responsibility of the caller via the function returned from listenSubscription.
  • Late emissions from a producer into a disposed transport are no longer silently dropped.

No API changes — only runtime behavior of host-api's transport returns to its pre-#196 state.

🤖 Generated with Claude Code

@cuteWarmFrog cuteWarmFrog self-assigned this Jun 4, 2026
@cuteWarmFrog cuteWarmFrog requested a review from johnthecat June 4, 2026 11:29
@cuteWarmFrog cuteWarmFrog merged commit 1fcbabd into main Jun 4, 2026
5 checks passed
@johnthecat johnthecat deleted the revert-196-transport-dispose branch June 11, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants