fix(host-papp): derive V2 session key from ECDH shared secret#206
Merged
Conversation
justraman
force-pushed
the
fix/v2-shared-secret-session-key
branch
from
9e06be9 to
b1bc805
Compare
johnthecat
approved these changes
Jun 5, 2026
johnthecat
added a commit
that referenced
this pull request
Jun 12, 2026
Main (0.8.7) had independently absorbed nearly all of this branch's work via PRs #178/#202/#205/#206/#212/#215/#216, with newer/cleaner versions. Conflict resolution (38 files): - package.json (x14), package-lock.json, CHANGELOG.md, migration doc: took main (newer versions, canonical release history). Dropped the unused `verifiablejs` dep. - All SSO V2, statement-store, handoff-service, and host-chat *impl* files: took main — strictly newer (ECDH session-key derivation #206, RFC-7 entropy #205, statement-store fix #215). The branch's parallel May implementations are superseded. - watchIdentity series: already identical in main (no real conflict). - Kept BRANCH version for two files where it is genuinely ahead: * identity/rpcAdapter.ts — defensive snake_case/camelCase Resources decode (fixes "Unknown user" regression on V2 runtime); a clean superset of main's version. * host-chat/codec/attachment.spec.ts — extra blurhash-thumbnail and NodeEndpoint round-trip tests against a byte-identical codec impl. Verified: build, typecheck, lint (0 errors), 679/679 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If host-papp is the public SDK for hosts, it has to ship the V2 contract by default. Hiding part of it behind polkadot desktop turns host-papp into a trap for others, desktop is not the only host.
Please don't ship spec migrations this way: bump the adapter alongside the spec. And if keeping the existing path working mattered, exporting
createV2Sessionwould have been the move.This one cost hours to debug.