Refactor codegen (#68)

* bring back Status enum

* refactor codgen

* remove static code from codegen

* more cleanup

* Polish truapi codegen display naming

* Fix typecheck and playground default for resource allocation example

- Use value: undefined (not null) for unit variants of the mixed
  AllocatableResource enum in the rustdoc client example so the
  generated example file typechecks under tsc -p tsconfig.examples.json.
- Drop the post-JSON collapse_tag_only_objects step in the playground
  codegen. It was over-eager: any { tag: "X" } object was rewritten to
  the bare string "X", which breaks mixed enums where the wire codec
  requires a tagged object. Unit-only enums already render as bare
  strings at the source.
- Remove stray empty doc lines in calls.rs, local_storage.rs and
  permissions.rs, and reformat the rustdoc display-name test per
  nightly rustfmt.

* Replace consecutive writeln! blocks with writedoc!

The explorer registry and playground services writers had many
multi-line writeln! formats for adjacent fixed-shape lines. Group
those into single writedoc! blocks with named arguments. Generated
output is byte-identical.

* Collapse more multi-writeln blocks in ts.rs

- Use writedoc! for the three-line generic codec function definition.
- Use named-capture interpolation so single multi-line writeln! formats
  collapse to one line.
- Fold the wire_version response decode branch into one writeln! with a
  conditional suffix.
- Fold write_payload_field's two branches into a single writeln! by
  building the encoded argument up front.
- Collapse the trailing close-brace + blank-line pair after each
  generated client class into one writeln!.

* Make value optional for unit variants of mixed enums

Generated types now emit `{ tag: "X"; value?: undefined }` for unit
variants in mixed enums, so consumers can write `{ tag: "X" }` without
the `value: undefined` placeholder.

To keep the codec assignable to the public type:
- Add S.TaggedUnion in scale.ts that wraps scale-ts's Enum and narrows
  unit-variant codecs (Codec<undefined>) to `value?: undefined`.
- Refine indexedTaggedUnion's variant type the same way, so versioned
  wrappers with V<N>(_void) variants follow the same convention.

Update the resource_allocation rustdoc example accordingly.

* rename truapiCall -> System

* flatten

* merge apis

* rename

* rename path / get rid legcacy

* Fix codegen drift and refresh explorer icon map

- Normalize single-quoted TS string literals to double-quoted JSON in
  playground default-request extraction so examples like
  `message: '{"jsonrpc":...}'` round-trip through serde_json.
- Apply nightly rustfmt to api/payment.rs, api/statement_store.rs, and
  v01/chain.rs.
- Update explorer group icons for the renamed groups (account, chain) and
  add icons for entropy, json-rpc, permissions, resource-allocation,
  theme, transaction.

* fix

* fix rewiring

* rm reordering

* fix

* remove explorer

* fix clippy

* fix clippy ref

* remove hard-coded service fields

* playground: fix Transaction → Signing method routing

The `Transaction` trait was merged back into `Signing` but the
playground bridge and auto-test still referenced `"transaction"` as a
`TrUApiClient` key, causing a TS build failure.

Route `create_transaction` and `create_transaction_with_legacy_account`
through `signing` to match the generated client.

---------

Co-authored-by: Filippo Vecchiato <filippo@parity.io>

Author: pgherveou

.claude/skills/regen-codegen/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: regen-codegen
-description: Regenerate the @parity/truapi TypeScript client and playground/explorer metadata from the truapi crate's rustdoc JSON. Use whenever the Rust trait surface changes.
+description: Regenerate the @parity/truapi TypeScript client and playground metadata from the truapi crate's rustdoc JSON. Use whenever the Rust trait surface changes.
 ---
 
 # Regenerate the TypeScript client
@@ -14,7 +14,7 @@ not change rustdoc output) or purely TS-side.
 ```
 
 Expected output: `Generated client at js/packages/truapi/src/generated/`,
-`Generated playground metadata ...`, `Generated explorer registry ...`.
+`Generated playground metadata ...`.
 
 The script is `cargo +nightly rustdoc --output-format json` →
 `truapi-codegen` → `prettier --write` → `npm run build` in
@@ -24,8 +24,7 @@ The script is `cargo +nightly rustdoc --output-format json` →
 
 ```bash
 git status js/packages/truapi/src/generated \
-           js/packages/truapi/src/playground \
-           js/packages/truapi/src/explorer
+           js/packages/truapi/src/playground
 git diff   js/packages/truapi/src/generated/
 ```
 

.claude/skills/truapi-definition-of-done/SKILL.md

@@ -30,7 +30,7 @@ git submodule update --init --recursive
       cargo commands clean.
 - [ ] **Codegen** — only if Rust trait surface changed. Invoke the
       `regen-codegen` skill, then commit
-      `js/packages/truapi/src/{generated,playground,explorer}/`.
+      `js/packages/truapi/src/{generated,playground}/`.
 - [ ] **`@parity/truapi`** — invoke the `ts-client-checks` skill.
       `npm run build && npm test` clean.
 - [ ] **Playground snapshot** — only if codegen ran or

.github/workflows/ci.yml

@@ -24,11 +24,9 @@ jobs:
 
       - uses: dtolnay/rust-toolchain@nightly
         with:
-          components: rustfmt
+          components: rustfmt, clippy
 
       - uses: dtolnay/rust-toolchain@stable
-        with:
-          components: clippy
 
       - uses: Swatinem/rust-cache@v2
 
@@ -38,8 +36,8 @@ jobs:
       - name: cargo +nightly fmt --check
         run: cargo +nightly fmt --check
 
-      - name: cargo clippy
-        run: cargo clippy --workspace --all-targets --all-features -- -D warnings
+      - name: cargo +nightly clippy
+        run: cargo +nightly clippy --workspace --all-targets --all-features -- -D warnings
 
       - name: cargo test
         run: cargo test --workspace --all-features
@@ -70,13 +68,11 @@ jobs:
         run: |
           if ! git diff --quiet --exit-code -- \
               js/packages/truapi/src/generated \
-              js/packages/truapi/src/playground \
-              js/packages/truapi/src/explorer; then
+              js/packages/truapi/src/playground; then
             echo "::error::Generated TypeScript is out of date. Run ./scripts/codegen.sh and commit the result."
             git --no-pager diff -- \
               js/packages/truapi/src/generated \
-              js/packages/truapi/src/playground \
-              js/packages/truapi/src/explorer
+              js/packages/truapi/src/playground
             exit 1
           fi
 
@@ -132,29 +128,6 @@ jobs:
         working-directory: playground
         run: yarn lint
 
-  explorer:
-    name: Explorer (build + lint)
-    runs-on: ubuntu-latest
-    needs: ts-client
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 22
-
-      - name: Build @parity/truapi
-        run: npm ci --prefix js/packages/truapi && npm run build --prefix js/packages/truapi
-
-      - name: Install explorer deps
-        run: npm ci --prefix explorer
-
-      - name: Build
-        run: npm run build --prefix explorer
-
-      - name: Lint
-        run: npm run lint --prefix explorer
-
   e2e:
     name: E2E (playground inside dotli)
     # Temporarily disabled while the dotli playground smoke test is stabilized.

.github/workflows/deploy-docs.yml

@@ -0,0 +1,66 @@
+name: Deploy Docs
+
+on:
+  push:
+    branches: [main]
+  workflow_dispatch:
+
+concurrency:
+  group: pages
+  cancel-in-progress: false
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+
+      - uses: Swatinem/rust-cache@v2
+
+      - name: Configure Pages
+        uses: actions/configure-pages@v5
+
+      - name: Build Rust API docs
+        run: cargo doc -p truapi --no-deps
+
+      - name: Redirect site root to crate docs
+        run: |
+          cat > target/doc/index.html <<'EOF'
+          <!doctype html>
+          <html lang="en">
+            <head>
+              <meta charset="utf-8">
+              <meta http-equiv="refresh" content="0; url=./truapi/">
+              <link rel="canonical" href="./truapi/">
+              <title>TrUAPI Docs</title>
+            </head>
+            <body>
+              <p>Redirecting to <a href="./truapi/">TrUAPI docs</a>…</p>
+            </body>
+          </html>
+          EOF
+          cp target/doc/index.html target/doc/404.html
+          touch target/doc/.nojekyll
+
+      - name: Upload Pages artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: target/doc
+
+  deploy:
+    needs: build
+    runs-on: ubuntu-latest
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+    steps:
+      - name: Deploy to GitHub Pages
+        id: deployment
+        uses: actions/deploy-pages@v4

.github/workflows/deploy-explorer.yml

@@ -13,8 +13,7 @@ rust/crates/
   truapi-macros/         #[wire(id = N)] proc-macro
 js/packages/
   truapi/         @parity/truapi TS package; src/generated/ produced by truapi-codegen
-explorer/               Vite documentation explorer; deploys to GitHub Pages
-playground/              Next.js interactive explorer; deploys to truapi-playground.dot
+playground/              Next.js interactive playground; deploys to truapi-playground.dot
 hosts/dotli/             dotli submodule
 docs/                    design docs, RFCs, feature proposals
 scripts/codegen.sh       regenerate the TS client from the Rust crate
@@ -24,6 +23,8 @@ scripts/codegen.sh       regenerate the TS client from the Rust crate
 
 - Every `pub` Rust item (functions, methods, types, traits, modules, constants) carries a doc comment (`///` or `//!`).
   Keep it short and focused on intent or invariants, not on what the signature already says.
+- Do not add code comments or doc comments that narrate migrations, compatibility shims, or historical changes. Comments should describe only the current code.
+- Remove legacy compatibility code by default. Keep or add it only when explicitly requested.
 - In Rust format strings, prefer inlined variables: `"log value: {value:?}"` over `"log value: {:?}", value`.
 
 ## First-time setup
@@ -48,7 +49,7 @@ When the Rust trait surface changes, rerun:
 ```
 
 That will repopulate `js/packages/truapi/src/generated/`. Commit the regenerated files alongside the Rust changes.
-It also regenerates playground metadata in `js/packages/truapi/src/playground/` and explorer metadata in `js/packages/truapi/src/explorer/`.
+It also regenerates playground metadata in `js/packages/truapi/src/playground/codegen/`.
 After regenerating, rebuild the client and refresh the playground's link copy:
 
 ```bash
@@ -65,7 +66,7 @@ After regenerating, rebuild the client and refresh the playground's link copy:
 ```bash
 cargo build --workspace
 cargo +nightly fmt --check
-cargo clippy --workspace --all-targets -- -D warnings
+cargo clippy --workspace --all-targets --all-features -- -D warnings
 cargo test --workspace
 ```
 
@@ -95,16 +96,7 @@ submodule init + `bun install` and the per-pane `cd` discipline).
 Alternatively, with a deployed Polkadot Desktop Host installed, navigate to
 `https://dot.li/localhost:3000` from within it.
 
-### Explorer
-
-```bash
-cd explorer
-npm run dev             # Vite dev server
-npm run build           # static GitHub Pages build to dist/
-npm run lint            # TypeScript checks
-```
-
 ## Deployment
 
-Pushes to `main` trigger `.github/workflows/deploy.yml`, which builds `playground/` and publishes the static export to `truapi-playground.dot` via `bulletin-deploy`.
-Pushes to `main` also trigger `.github/workflows/deploy-explorer.yml`, which builds `explorer/` and publishes it to GitHub Pages.
+Pushes to `main` trigger `.github/workflows/deploy-playground.yml`, which builds `playground/` and publishes the static export to `truapi-playground.dot` via `bulletin-deploy`.
+Pushes to `main` also trigger `.github/workflows/deploy-docs.yml`, which publishes the Rust API docs to GitHub Pages.

CLAUDE.md

@@ -44,7 +44,7 @@ Canonical design documentation lives in `docs/design/`. To propose updates or ad
 ### Prerequisites
 
 - Rust toolchain (stable + nightly for `cargo fmt`)
-- Node.js and npm (for the TypeScript client and explorer)
+- Node.js and npm (for the TypeScript client)
 - Yarn 1.x (for the playground)
 
 ### Repository layout
@@ -56,8 +56,7 @@ rust/crates/
   truapi-macros/       #[wire(id = N)] proc-macro
 js/packages/
   truapi/              @parity/truapi TypeScript package (src/generated/ is auto-generated)
-explorer/              Vite documentation explorer (GitHub Pages)
-playground/            Next.js interactive explorer
+playground/            Next.js interactive playground
 hosts/dotli/           dotli host (git submodule)
 scripts/codegen.sh     regenerate the TS client from the Rust crate
 ```
@@ -109,7 +108,7 @@ TrUAPI protocol. When you modify traits or types there:
 # Rust
 cargo build --workspace
 cargo +nightly fmt --check
-cargo clippy --workspace --all-targets -- -D warnings
+cargo clippy --workspace --all-targets --all-features -- -D warnings
 cargo test --workspace
 
 # TypeScript client

CONTRIBUTING.md

@@ -1,3 +1,6 @@
 [workspace]
 resolver = "2"
 members = ["rust/crates/*"]
+
+[workspace.package]
+edition = "2024"