feat: port Rust core runtime by pgherveou · Pull Request #104 · paritytech/truapi

pgherveou · 2026-05-17T01:21:14Z

Summary

This PR ports dotli onto the shared Rust TrUAPI core and makes the Rust crates the source of truth for protocol dispatch, generated product/client types, host capability bindings, auth/session state, permissions, SSO/signing orchestration, chainHead, preimage, theme, and notification plumbing.

The web host now embeds the Rust runtime through @parity/truapi-host-wasm. dotli keeps the browser-specific pieces: iframe/worker transport, DOM presentation, storage adapters, and chain-provider wiring. Native/mobile scaffolding continues in #215.

Reviewable stack

This PR is the umbrella / cumulative view. For review, it is broken into a per-commit stack. Please review and merge bottom-up. The tip, #253, has the same cumulative diff as this PR.

feat(truapi): add testing API and versioned wiring #248 — truapi: testing API + versioned wiring (base: main)
feat(truapi-platform): add host capability traits #249 — truapi-platform: host capability traits
feat(truapi-codegen): emit Rust dispatcher, wire table, and host callbacks #254 — truapi-codegen: Rust dispatcher + wire table
feat(truapi-server): add host logic primitives #255 — truapi-server: host logic primitives
feat(truapi-server): add wire and chain infrastructure #256 — truapi-server: wire and chain infrastructure
feat(truapi-server): add platform runtime and host bridge #250 — truapi-server: platform runtime and host bridge
feat(host-wasm): add @parity/truapi-host-wasm runtime #252 — host-wasm: @parity/truapi-host-wasm runtime
chore: docs, CI, tooling, and dotli integration for the Rust core #253 — docs, CI, tooling, dotli integration

Architecture

Vision: Shared Core SDK
design: Shared Rust Core Host Architecture

Validation

make check
make e2e-dotli with signer-bot should give you the same report as published in the explorer
make dev will build and run so you can test the truapi-playground locally, running http://localhost:5173/localhost:3000

socket-security · 2026-05-17T01:21:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
cargo/web-sys@0.3.98
npm/@polkadot-api/utils@0.1.2 ⏵ 0.4.0		^-1	^-1
npm/@polkadot-api/substrate-bindings@0.12.0 ⏵ 0.20.2	⁺¹	⁺¹
cargo/thiserror@1.0.69
cargo/wasm-bindgen@0.2.121
cargo/subxt-rpcs@0.50.1
cargo/blake2-rfc@0.2.18
cargo/console_error_panic_hook@0.1.7
cargo/send_wrapper@0.6.0
cargo/sp-crypto-hashing@0.1.0
cargo/aes-gcm@0.10.3
cargo/async-trait@0.1.89
cargo/bs58@0.5.1
cargo/futures-timer@3.0.3
cargo/getrandom@0.2.17
cargo/hkdf@0.12.4
cargo/p256@0.13.2
cargo/pin-project@1.1.13
cargo/primitive-types@0.13.1
cargo/schnorrkel@0.11.5
cargo/sha2@0.10.9
cargo/tempfile@3.27.0
cargo/tracing@0.1.44
cargo/tracing-subscriber@0.3.23
cargo/wasm-bindgen-futures@0.4.71
cargo/wasm-bindgen-test@0.3.71
cargo/web-time@1.1.0
cargo/js-sys@0.3.98
npm/@polkadot-api/metadata-builders@0.14.2
cargo/url@2.5.8
cargo/unicode-normalization@0.1.25
npm/@parity/truapi@0.3.1 ⏵ 0.0.0	⁺²¹	⁺¹	⁺⁷

View full report

@Suppress

Bug fixes: - Makefile uniffi target now writes Swift bindings through a tempdir and copies into the actual SwiftPM layout (Sources/TrUAPIHost/ for the .swift file, Sources/truapi_serverFFI/include/ for the C header and module.modulemap). Cdylib path picks .dylib on macOS. - electron provider: onClose sets disposed=true and clears listener sets so subsequent postMessage no-ops cleanly and close listeners don't fire twice if the caller also calls dispose(). - web worker provider: init-failure paths call worker.terminate() before rejecting so a failed core init doesn't leak the worker. - createWebSocketProvider: subscribe / subscribeClose use Set instead of Array+indexOf so double-registration of the same callback is idempotent (matches the other providers in the package). Test coverage: - New js/packages/truapi/test/ws-provider.test.mjs exercises the WS provider against a stubbed WebSocket constructor (queue+flush, fan-out, set semantics, close fan-out, post-after-close throws). Doc + style fixes: - docs/design/dotli-architecture-change.md describes featureSupported as a current callback with a planned removal, matching the platform trait and the host shells. The implementation-vs-doc contradiction is gone. - Migration narrative stripped from runtime.rs, wasm.rs, native.rs, host_logic/features.rs, the Kotlin shell, and the Swift shell. - Em-dashes swept from 18 PR-scope files (CLAUDE.md, both design docs, both native READMEs, the TS host packages, a few platform doc comments). - create-iframe-host.ts comment now describes current behaviour without referencing the "legacy fallback". - tests/object_safety.rs renamed to tests/bounds.rs with a docstring that matches what the test actually asserts (the trait isn't object-safe; the bound check is on Send + Sync + 'static). - iOS: drop dead `_ = self.callbackRetainer` line; explain the retainer in plain prose instead of via a no-op suppression. - Android: drop redundant @Suppress("unused") on a property that is read in init. Deferred to follow-up issues (#105-#111).

Harden the Rust core runtime and host SDKs against the review of the core port. No change to the wire protocol or the generated artifacts (codegen regenerates byte-identically; the committed WASM bundle is rebuilt). truapi-server: - Subscriptions use generation-stamped reservation slots: a reused or raced request_id stops-and-replaces instead of leaking an unstoppable stream, and a _stop arriving before activation cancels the pending subscription. Unregistered methods answer Unsupported instead of leaving the caller to hang. Dead negotiated_version slot and interrupt API removed. - chainHead-v1 runtime: single-flight follow setup (no duplicate or leaked remote subscriptions), the close-vs-insert race in request_value is closed so a caller can no longer hang forever, the pending follow-event buffer is bounded, and an orphaned remote follow is unfollowed when its local follow is torn down mid-setup. - WS bridge: constant-time token comparison, bounded inbound message size, bounded outbound queue and connection count, documented loopback trust model. - wasm surface registers a panic hook and surfaces non-boolean / non-string host returns as errors; permissions persist only genuine user decisions, so a transient prompt-callback error no longer locks a capability out; dotns classifies trailing-dot FQDNs and lowercases/de-dupes remote domains; navigate_to returns an error instead of panicking on a contract violation. - smoldot provider is wired into the runtime behind its feature (with a platform fallback), with finite json-rpc ceilings, a distinguishable reconnect error, and Apache-2.0 attribution (SPDX headers + THIRD_PARTY_NOTICES.md). - Tests: subscription-race regressions, malformed-frame drop, subscription lifecycle through the wire boundary, and a hardened Rust<->TS wire-table parity check (panics on unparseable ids, compares all four subscription ids, asserts a row-count floor). codegen: Rust dispatcher/wire-table emitters use writedoc!/formatdoc! (byte-identical output); TS host-callbacks handles bare trait-object returns. JS hosts: worker-runtime faults now reach close subscribers; the WebSocket provider is built on the shared close-once base provider; the electron provider detaches port listeners on remote close; new tests for the node WASM round-trip, WS error/non-binary/CLOSING paths, and the iframe handshake/origin/dispose paths. native: Android and iOS HostBridge document that callbacks fire on the truapi-ws-bridge worker thread; the iOS bootstrap uses a JSONEncoder-based JS string-literal escaper; Maven coordinates reconciled across build.gradle.kts, jitpack.yml, and the README. CI/docs: host-packages CI runs the host-shared smoke test against the freshly built WASM bundle and triggers on truapi-platform changes; the Makefile wasm target no longer hides the committed bundle; design docs and the truapi-platform README are reconciled to the shipped trait set.

pgherveou · 2026-06-12T03:43:44Z

Superseded by a 3-PR stack carved from this branch, each independently reviewable and green on CI:

feat(core): port Rust core runtime, codegen, and WASM host #210 — feat(core): Rust core runtime, codegen, and WASM host (base main). Smallest slice that runs the dotli playground diagnosis e2e.
feat(mobile): add iOS and Android UniFFI host packages #211 — feat(mobile): iOS + Android UniFFI host packages (base feat(core): port Rust core runtime, codegen, and WASM host #210).
docs: add design docs, RFCs, and refresh top-level docs #212 — docs: design docs, RFCs, and refreshed top-level docs (base feat(mobile): add iOS and Android UniFFI host packages #211).

Review bottom-up. Authored with assistance from Claude Code.

pgherveou · 2026-06-12T13:25:25Z

Follow-up update: PR #214 was merged back into this PR branch so the parent can run e2e, and #214 is now closed as superseded. Mobile host scaffolding/config/CI moved to child PR #215.

The truapi-ready/truapi-init handshake pairs with the WASM host's createIframeHost (#104). Keep sandbox.ts at base so merging to main does not break the deployed playground against the current host.

pgherveou

Addressed review cleanup comments.

pgherveou

.

Adds the canonical testing module (api/testing.rs) and its v01/v02/versioned wiring used by the Rust host runtime and generated clients.

New crate defining the host syscall traits (storage, navigation, consent, permissions, ...) that host runtimes implement. Types are re-exported from truapi::versioned/v01 rather than redefined.

WASM host runtime that hosts implement: dispatcher, SCALE frames, subscription streams, chain runtime, host logic (sessions, SSO pairing, permissions, statement store, dotns) and the wasm bindings. Includes the committed generated dispatcher/wire-table under src/generated/.

…backs Extends the rustdoc-JSON code generator to emit the Rust dispatcher and wire table consumed by truapi-server, plus the TS host-callbacks adapter. Golden tests pin the emitted shapes.

New WASM-backed host runtime package embedding the Rust core, with web iframe and Web Worker entry points. Updates the @parity/truapi client (SCALE, sandbox, transport) and drops the obsolete explorer 0.3.2 codegen snapshot.

Updates CLAUDE.md/README, CI workflows, Makefile, deny.toml, changesets, and linguist attributes for generated code, and bumps the dotli submodule to the host integration that consumes the WASM runtime.

pgherveou · 2026-06-30T21:52:37Z

This PR has been broken down into a stack of per-commit PRs for easier review. This PR stays open as the umbrella / cumulative view. Please review and merge the stack bottom-up:

feat(truapi): add testing API and versioned wiring #248 — truapi: testing API + versioned wiring (base: main)
feat(truapi-platform): add host capability traits #249 — truapi-platform: host capability traits
feat(truapi-server): add platform runtime and host bridge #250 — truapi-server: Rust host runtime
feat(truapi-codegen): emit Rust dispatcher, wire table, and host callbacks #251 — truapi-codegen: Rust dispatcher + wire table
feat(host-wasm): add @parity/truapi-host-wasm runtime #252 — host-wasm: @parity/truapi-host-wasm runtime
chore: docs, CI, tooling, and dotli integration for the Rust core #253 — docs, CI, tooling, dotli integration

Each PR is based on the one below it; the tip (#253) has the same cumulative diff as this PR.

Adapt the mock platform to #104's async_trait capability traits and truapi::latest types: add #[async_trait] to each capability impl, flatten feature_supported to bare v01 request/response types, update CoreStorageKey::PermissionAuthorization to { product_id, request }, and add JsonRpcConnection::close. Fix the through-core preimage + storage-fault tests to assert the Result discriminant at wire byte 1: the versioned envelope is [version_index, result_discriminant, ..inner], and V1's version index is 0, so the Ok/Err distinction lives at byte 1, not byte 0.

pgherveou requested a review from a team May 17, 2026 01:21

pgherveou mentioned this pull request May 17, 2026

Port Rust core (truapi-server + host runtime SDKs) from truapi_next prototype #96

Closed

pgherveou marked this pull request as draft May 17, 2026 16:22

pgherveou mentioned this pull request May 18, 2026

host-electron + host-web: small robustness items from PR review #111

Open

pgherveou changed the title ~~feat: port Rust core runtime from truapi_next prototype~~ feat: port Rust core runtime May 18, 2026

pgherveou mentioned this pull request May 20, 2026

refactor: small cleanups extracted from #96 prep work #124

Merged

This was referenced Jun 11, 2026

feat(core): port Rust core runtime, codegen, and WASM host #210

Closed

feat(mobile): add iOS and Android UniFFI host packages #211

Closed

docs: add design docs, RFCs, and refresh top-level docs #212

Closed

pgherveou closed this Jun 12, 2026

pgherveou reopened this Jun 12, 2026

pgherveou commented Jun 12, 2026

View reviewed changes

pgherveou mentioned this pull request Jun 12, 2026

Move playground iframe host integration #214

Closed

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from 341366d to c5fb5c9 Compare June 14, 2026 09:29

This was referenced Jun 25, 2026

Port the dot.li web host to the shared TrUAPI Rust core paritytech/dotli-community#54

Draft

Playground e2e harness + SCALE codec additions #238

Merged

pgherveou changed the base branch from main to slim/js-playground-extract June 26, 2026 10:22

Base automatically changed from slim/js-playground-extract to main June 26, 2026 10:48

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from a0793b9 to 5f03570 Compare June 28, 2026 10:00

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from eec4794 to 58e8db3 Compare June 30, 2026 11:02

pgherveou commented Jun 30, 2026

View reviewed changes

Comment thread rust/crates/truapi/src/v01/testing.rs Outdated

Comment thread rust/crates/truapi/src/lib.rs Outdated

Comment thread rust/crates/truapi-platform/src/lib.rs Outdated

Comment thread rust/crates/truapi-platform/src/lib.rs

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from 58e8db3 to c992e4c Compare June 30, 2026 11:17

pgherveou commented Jun 30, 2026

View reviewed changes

Comment thread rust/crates/truapi-platform/src/lib.rs

pgherveou force-pushed the worktree-issue-96-rust-core-port branch 2 times, most recently from 2b612da to 589e7dc Compare June 30, 2026 12:35

feat(truapi): add testing API and versioned wiring

a302550

Adds the canonical testing module (api/testing.rs) and its v01/v02/versioned wiring used by the Rust host runtime and generated clients.

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from d1d0e97 to 30032e9 Compare June 30, 2026 15:30

pgherveou added 5 commits June 30, 2026 23:28

feat(truapi-platform): add host capability traits

4b83619

New crate defining the host syscall traits (storage, navigation, consent, permissions, ...) that host runtimes implement. Types are re-exported from truapi::versioned/v01 rather than redefined.

feat(truapi-codegen): emit Rust dispatcher, wire table, and host call…

1c8334a

…backs Extends the rustdoc-JSON code generator to emit the Rust dispatcher and wire table consumed by truapi-server, plus the TS host-callbacks adapter. Golden tests pin the emitted shapes.

feat(host-wasm): add @parity/truapi-host-wasm runtime

b137a87

New WASM-backed host runtime package embedding the Rust core, with web iframe and Web Worker entry points. Updates the @parity/truapi client (SCALE, sandbox, transport) and drops the obsolete explorer 0.3.2 codegen snapshot.

chore: docs, CI, tooling, and dotli integration for the Rust core

4c04a81

Updates CLAUDE.md/README, CI workflows, Makefile, deny.toml, changesets, and linguist attributes for generated code, and bumps the dotli submodule to the host integration that consumes the WASM runtime.

pgherveou force-pushed the worktree-issue-96-rust-core-port branch from 590abd1 to 4c04a81 Compare June 30, 2026 21:34

This was referenced Jul 1, 2026

feat(truapi-codegen): emit Rust dispatcher, wire table, and host callbacks #254

Open

feat(truapi-server): add host logic primitives #255

Open

feat(truapi-server): add wire and chain infrastructure #256

Open

decrypto21 mentioned this pull request Jul 1, 2026

Add an in-core mock host: MockPlatform + createMockHost #257

Open

decrypto21 mentioned this pull request Jul 1, 2026

Feat/mock platform #258

Draft

fixup! feat: port Rust core runtime

f898de6

pgherveou mentioned this pull request Jul 1, 2026

feat: add Rust host runtime boundary #247

Closed

fixup! feat: port Rust core runtime

3faed7e

Uh oh!

Conversation

pgherveou commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Reviewable stack

Architecture

Validation

Uh oh!

socket-security Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Jun 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pgherveou commented Jun 12, 2026

Uh oh!

pgherveou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pgherveou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pgherveou commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pgherveou commented May 17, 2026 •

edited

Loading

socket-security Bot commented May 17, 2026 •

edited

Loading

pgherveou left a comment •

edited

Loading