feat(truapi-codegen): emit Rust dispatcher, wire table, and host callbacks#254
Open
pgherveou wants to merge 1 commit into
Open
feat(truapi-codegen): emit Rust dispatcher, wire table, and host callbacks#254pgherveou wants to merge 1 commit into
pgherveou wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This was referenced Jul 1, 2026
pgherveou
force-pushed
the
rust-core/04-codegen
branch
from
2cc45b1 to
8ad3cf9
Compare
pgherveou
force-pushed
the
rust-core/02-platform-traits
branch
from
1a7d349 to
0a7b831
Compare
…backs Extends the rustdoc-JSON code generator to emit the Rust dispatcher and wire table consumed by truapi-server, plus the TS host-callbacks adapter. Golden tests pin the emitted shapes.
pgherveou
force-pushed
the
rust-core/04-codegen
branch
from
8ad3cf9 to
8ddbe78
Compare
pgherveou
force-pushed
the
rust-core/02-platform-traits
branch
from
0a7b831 to
d2454f8
Compare
TarikGul
reviewed
Jul 2, 2026
| method.params.len() | ||
| ), | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| if matches!(method.kind, MethodKind::Subscription | MethodKind::ResultSubscription) | |
| && matches!(request_payload, Some(WirePayload::Raw(_))) | |
| { | |
| bail!( | |
| "Method `{}`: subscription request parameters must be versioned wrappers \ | |
| (got a non-versioned type); the dispatcher cannot decode a raw subscription request", | |
| method.name | |
| ); | |
| } |
Might be worth having this kind of guard.
TarikGul
reviewed
Jul 2, 2026
| let fn_name = format!("register_{module}"); | ||
| let trait_name = &trait_def.name; | ||
| let mut code = String::new(); | ||
| if trait_name == "Testing" { |
Member
There was a problem hiding this comment.
I am seeing a lot of checks for trait_name == "Testing", it might be worth having a single helper for this to make sure it never drifts etc.
TarikGul
reviewed
Jul 2, 2026
| /// Walk the platform crate and extract every public trait + its methods. | ||
| pub fn extract(krate: &Crate) -> Result<PlatformDefinition> { | ||
| let trait_ids = collect_local_trait_ids(krate); | ||
| let names = NameContext::default(); |
Member
There was a problem hiding this comment.
Is an empty NameContext here intentional?
TarikGul
reviewed
Jul 2, 2026
| let Some(name) = item_path.path.last() else { | ||
| continue; | ||
| }; | ||
| if !referenced.contains(name) || extracted.contains(name) { |
Member
There was a problem hiding this comment.
Suggested change
| if !referenced.contains(name) || extracted.contains(name) { | |
| if !referenced.contains(name) { | |
| continue; | |
| } | |
| if let Some(existing_module) = extracted.get(name) { | |
| if existing_module != &item_path.path[..item_path.path.len() - 1] { | |
| bail!( | |
| "platform type name `{name}` is ambiguous: defined in both \ | |
| `{}` and `{}`", | |
| existing_module.join("::"), | |
| item_path.path[..item_path.path.len() - 1].join("::"), | |
| ); | |
| } | |
| continue; // same type already extracted — normal dedup | |
| } |
Could be a better guard as well.
TarikGul
reviewed
Jul 2, 2026
| Some(response) => { | ||
| let target_version_expr = target_version_expr | ||
| .as_deref() | ||
| .expect("versioned responses require a target version"); |
Member
There was a problem hiding this comment.
Suggested change
| .expect("versioned responses require a target version"); | |
| .ok_or_else(|| anyhow::anyhow!( | |
| "Method `{}`: versioned response with a non-versioned (raw) request \ | |
| has no target version to encode against", self.name))? |
Might be better swapping the panics with a bail!
TarikGul
reviewed
Jul 2, 2026
| ) | ||
| .unwrap(); | ||
| if is_result_sub { | ||
| let _ = error.expect("result subscription methods must have an error wrapper"); |
Member
There was a problem hiding this comment.
Suggested change
| let _ = error.expect("result subscription methods must have an error wrapper"); | |
| let error = error.ok_or_else(|| anyhow::anyhow!( | |
| "Method `{}`: result-subscription error type must be a versioned wrapper", self.name))?; |
Same panic vs bail here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the rustdoc-JSON code generator to emit the Rust dispatcher and wire table consumed by
truapi-server, plus the TS host-callbacks adapter. Golden tests pin the emitted shapes.This replaces #251 after reordering the stack so the codegen layer can be reviewed and merged before the server runtime layer.
Stack
Part of the Rust core runtime port (umbrella: #104), split into a reviewable stack. Merge bottom-up.