Move tests

These tests used `assert_cmd::carg::cargo_bin`, which is deprecated.
It is meant to be replaced with the macro `assert_cmd::cargo_bin!`,
which required tests to be moved to the `cli` crate.
If tests hadn't been moved, that macro would fail to find the binary,
as the `CARGO_BIN_EXE_*` environment variable with the absolute path
to a binary target’s executable would not have been set.
Moving the tests causes it to be set, and the macro then works.

Author: rockbmb

core/tests/create_snapshot.rs cli/tests/create_snapshot.rscore/tests/create_snapshot.rs renamed to cli/tests/create_snapshot.rs

@@ -16,14 +16,13 @@
 // limitations under the License.
 
 #![cfg(unix)]
-#![allow(deprecated)]
 
 use std::{
     path::{Path, PathBuf},
     time::Duration,
 };
 
-use assert_cmd::cargo::cargo_bin;
+use assert_cmd::cargo_bin;
 use frame_remote_externalities::{Builder, Mode, OfflineConfig, SnapshotConfig};
 use sp_runtime::{
     generic::{Block, Header},
@@ -43,7 +42,11 @@ async fn create_snapshot_works() {
         match common::start_node_inline(vec![
             "--no-hardware-benchmarks",
             "--dev",
+            "--tmp",
             format!("--rpc-port={}", port).as_str(),
+            "--no-telemetry",
+            "--no-prometheus",
+            "--rpc-max-response-size=1000", // Allow large RPC responses for snapshot creation
         ]) {
             Ok(_) => {}
             Err(e) => {
@@ -52,7 +55,7 @@ async fn create_snapshot_works() {
         }
     });
     // Wait some time to ensure the node is warmed up.
-    std::thread::sleep(Duration::from_secs(90));
+    std::thread::sleep(Duration::from_secs(180));
 
     // Run the command with tokio
     let temp_dir = tempfile::Builder::new()
@@ -67,7 +70,7 @@ async fn create_snapshot_works() {
             snap_file: &PathBuf,
             at: sp_core::H256,
         ) -> tokio::process::Child {
-            Command::new(cargo_bin("try-runtime"))
+            Command::new(cargo_bin!("try-runtime"))
                 .stdout(std::process::Stdio::piped())
                 .stderr(std::process::Stdio::piped())
                 .arg("--runtime=existing")