Fix clippy and formatting

Author: rockbmb

core/src/commands/on_runtime_upgrade/mod.rs

@@ -175,6 +175,7 @@ where
     /// Check that the migrations are idempotent.
     ///
     /// Expects the overlayed changes from the first execution of the migrations.
+    #[allow(clippy::result_large_err)]
     fn check_idempotency(
         &self,
         ext: &mut RemoteExternalities<Block>,
@@ -252,6 +253,7 @@ where
     }
 
     /// Check that the migrations don't use more weights than a block.
+    #[allow(clippy::result_large_err)]
     fn check_weight(&self, ext: &RemoteExternalities<Block>) -> sc_cli::Result<bool> {
         if self.command.no_weight_warnings {
             log::info!("ℹ Skipping weight safety check");
@@ -300,6 +302,7 @@ where
     }
 
     /// Whether any storage was changed.
+    #[allow(clippy::result_large_err)]
     fn changed(
         &self,
         ext: &RemoteExternalities<Block>,

core/src/common/empty_block/inherents/custom_idps/para_parachain.rs

@@ -120,8 +120,8 @@ impl<B: BlockT> sp_inherents::InherentDataProvider for InherentDataProvider<B> {
         ];
 
         // Check if `PendingValidationCode` exists in storage before setting `GoAhead`.
-        // The parachain-system pallet panics if `GoAhead` is provided without a pending validation code.
-        // See: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/pallets/parachain-system/src/lib.rs#L667
+        // The parachain-system pallet panics if `GoAhead` is provided without a pending validation
+        // code. See: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/pallets/parachain-system/src/lib.rs#L667
         let has_pending = has_pending_validation_code::<B>(ext);
         let upgrade_go_ahead = if has_pending {
             Some(UpgradeGoAhead::GoAhead)

core/src/common/empty_block/production.rs

@@ -217,13 +217,15 @@ async fn call<T: Decode, Block: BlockT, HostFns: HostFunctions>(
     T::decode(&mut &*result).map_err(|e| sc_cli::Error::Input(format!("{:?}", e)))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn core_version<Block: BlockT, HostFns: HostFunctions>(
     externalities: &TestExternalities<HashingFor<Block>>,
     executor: &WasmExecutor<HostFns>,
 ) -> Result<u32> {
     dry_call::<u32, Block, HostFns>(externalities, executor, "Core_version", &[])
 }
 
+#[allow(clippy::result_large_err)]
 /// Call `method` with `data` and return the result. `externalities` will not change.
 fn dry_call<T: Decode, Block: BlockT, HostFns: HostFunctions>(
     externalities: &TestExternalities<HashingFor<Block>>,

core/src/common/state.rs

@@ -89,6 +89,7 @@ pub struct LiveState {
 
 impl LiveState {
     /// Return the `at` block hash as a `Hash`, if it exists.
+    #[allow(clippy::result_large_err)]
     pub fn at<Block: BlockT>(&self) -> sc_cli::Result<Option<<Block>::Hash>>
     where
         <Block::Hash as FromStr>::Err: Debug,
@@ -365,6 +366,7 @@ fn ensure_try_runtime<Block: BlockT, HostFns: HostFunctions>(
 
 /// Execute the given `method` and `data` on top of `ext`, returning the results (encoded) and the
 /// state `changes`.
+#[allow(clippy::result_large_err)]
 pub(crate) fn state_machine_call<Block: BlockT, HostFns: HostFunctions>(
     ext: &TestExternalities<HashingFor<Block>>,
     executor: &WasmExecutor<HostFns>,
@@ -394,6 +396,7 @@ pub(crate) fn state_machine_call<Block: BlockT, HostFns: HostFunctions>(
 /// information.
 ///
 /// Make sure [`LOG_TARGET`] is enabled in logging.
+#[allow(clippy::result_large_err)]
 pub(crate) fn state_machine_call_with_proof<Block: BlockT, HostFns: HostFunctions>(
     ext: &TestExternalities<HashingFor<Block>>,
     storage_overlay: &mut OverlayedChanges<HashingFor<Block>>,

core/src/lib.rs

@@ -38,6 +38,7 @@ pub mod common;
 pub(crate) const LOG_TARGET: &str = "try-runtime::cli";
 
 /// Get the hash type of the generic `Block` from a `hash_str`.
+#[allow(clippy::result_large_err)]
 pub(crate) fn hash_of<Block: BlockT>(hash_str: &str) -> sc_cli::Result<Block::Hash>
 where
     <Block::Hash as FromStr>::Err: Debug,