Wire up fast-runtime feature flag for short timeouts (#210)

* Wire up fast-runtime feature flag for short timeouts

When built with --features fast-runtime, ChallengeTimeout,
SettlementTimeout, RequestTimeout, and DeregisterAnnouncementPeriod
use short block counts (3–10) instead of hours-long production values,
making provider deregistration and challenge flows practical on
previewnet.

* Enable fast-runtime by default in justfile build recipes

just start-chain and just start-paseo-chain now build with
--features fast-runtime so local testing uses short timeouts.

* Set short challenge/settlement timeouts directly; drop fast-runtime flag

Replace the fast-runtime feature gate on the timeout constants with the short
values baked directly into both the local (testnet) and paseo runtimes:
ChallengeTimeout=10, SettlementTimeout=5, RequestTimeout=3,
DeregisterAnnouncementPeriod=10 (still >= ChallengeTimeout). This makes
challenge and provider-deregistration flows practical on previewnet without a
separate feature build.

With the constants no longer feature-dependent, remove the now-dead
fast-runtime machinery: the second build.rs WASM binary, the
fast_runtime_binary module in lib.rs, the fast-runtime Cargo feature, and the
--features fast-runtime flags in the justfile build recipes. Drop the unused
time::HOURS import.

The released paseo wasm now carries the short timeouts by default; an existing
previewnet chain still needs a runtime upgrade (setCode) to pick them up.

Verified on remote: both runtimes build; cargo +nightly fmt --check, clippy -D warnings (both runtimes), taplo, and zepter all pass.

* paseo: make storage-provider parameters runtime-settable via setStorage

Convert the parameter_types! block in the paseo runtime from compile-time
`pub const` to storage-backed `pub storage`. Each value remains the default but
can now be overridden at runtime with `system.setStorage` (under sudo/governance)
without a runtime upgrade — so previewnet timings (challenge/settlement/request
timeouts, checkpoint cadence, stakes, deregister period) can be tuned live.

Each `pub storage X` reads from unhashed storage falling back to the default and
exposes X::key()/X::set(). Local (testnet) runtime is left as const.

Verified on remote: paseo runtime builds; cargo +nightly fmt --check passes.

* chore(release): v0.4.0-paseo

- storage-provider-node crate 0.3.0 -> 0.4.0 (release tag validation)
- storage-paseo-runtime crate 0.3.0 -> 0.4.0
- RuntimeVersion: spec_version 3_000 -> 4_000

Ships the paseo timeout changes (short challenge/settlement/request timeouts and
deregister period) and the storage-backed parameter_types (runtime-settable via
system.setStorage). No extrinsic encoding changes, so transaction_version stays
at 2; the spec_version bump triggers any on-chain migrations on upgrade.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

Author: mudigal

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "storage-provider-node"
-version = "0.3.0"
+version = "0.4.0"
 authors.workspace = true
 edition.workspace = true
 license.workspace = true

provider-node/Cargo.toml

@@ -228,6 +228,5 @@ try-runtime = [
 	"polkadot-runtime-common/try-runtime",
 	"sp-runtime/try-runtime",
 ]
-fast-runtime = []
 # Enable the metadata hash generation in the wasm builder.
 metadata-hash = ["substrate-wasm-builder/metadata-hash"]

runtimes/web3-storage-local/Cargo.toml

@@ -3,24 +3,13 @@
 #[cfg(all(not(feature = "metadata-hash"), feature = "std"))]
 fn main() {
     substrate_wasm_builder::WasmBuilder::build_using_defaults();
-
-    substrate_wasm_builder::WasmBuilder::init_with_defaults()
-        .set_file_name("fast_runtime_binary.rs")
-        .enable_feature("fast-runtime")
-        .build();
 }
 
 #[cfg(all(feature = "metadata-hash", feature = "std"))]
 fn main() {
     substrate_wasm_builder::WasmBuilder::init_with_defaults()
         .enable_metadata_hash("UNIT", 12)
         .build();
-
-    substrate_wasm_builder::WasmBuilder::init_with_defaults()
-        .set_file_name("fast_runtime_binary.rs")
-        .enable_feature("fast-runtime")
-        .enable_metadata_hash("UNIT", 12)
-        .build();
 }
 
 #[cfg(not(feature = "std"))]

runtimes/web3-storage-local/build.rs

@@ -12,14 +12,6 @@
 #[cfg(feature = "std")]
 include!(concat!(env!("OUT_DIR"), "/wasm_binary.rs"));
 
-/// Provides the `WASM_BINARY` build with `fast-runtime` feature enabled.
-///
-/// This is for example useful for local test chains.
-#[cfg(feature = "std")]
-pub mod fast_runtime_binary {
-    include!(concat!(env!("OUT_DIR"), "/fast_runtime_binary.rs"));
-}
-
 pub mod constants;
 mod genesis_config_presets;
 mod revive;

runtimes/web3-storage-local/src/lib.rs

@@ -1,6 +1,6 @@
 [package]
 name = "storage-paseo-runtime"
-version = "0.3.0"
+version = "0.4.0"
 authors.workspace = true
 edition.workspace = true
 license.workspace = true
@@ -236,6 +236,5 @@ try-runtime = [
 	"polkadot-runtime-common/try-runtime",
 	"sp-runtime/try-runtime",
 ]
-fast-runtime = []
 # Enable the metadata hash generation in the wasm builder.
 metadata-hash = ["substrate-wasm-builder/metadata-hash"]

runtimes/web3-storage-paseo/Cargo.toml

@@ -16,24 +16,13 @@
 #[cfg(all(not(feature = "metadata-hash"), feature = "std"))]
 fn main() {
     substrate_wasm_builder::WasmBuilder::build_using_defaults();
-
-    substrate_wasm_builder::WasmBuilder::init_with_defaults()
-        .set_file_name("fast_runtime_binary.rs")
-        .enable_feature("fast-runtime")
-        .build();
 }
 
 #[cfg(all(feature = "metadata-hash", feature = "std"))]
 fn main() {
     substrate_wasm_builder::WasmBuilder::init_with_defaults()
         .enable_metadata_hash("PAS", 10)
         .build();
-
-    substrate_wasm_builder::WasmBuilder::init_with_defaults()
-        .set_file_name("fast_runtime_binary.rs")
-        .enable_feature("fast-runtime")
-        .enable_metadata_hash("PAS", 10)
-        .build();
 }
 
 #[cfg(not(feature = "std"))]

runtimes/web3-storage-paseo/build.rs

@@ -12,14 +12,6 @@
 #[cfg(feature = "std")]
 include!(concat!(env!("OUT_DIR"), "/wasm_binary.rs"));
 
-/// Provides the `WASM_BINARY` build with `fast-runtime` feature enabled.
-///
-/// This is for example useful for local test chains.
-#[cfg(feature = "std")]
-pub mod fast_runtime_binary {
-    include!(concat!(env!("OUT_DIR"), "/fast_runtime_binary.rs"));
-}
-
 pub mod genesis_config_presets;
 pub mod migrations;
 pub mod paseo_constants;
@@ -186,9 +178,9 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     impl_name: Cow::Borrowed("paseo-web3-storage-runtime"),
     authoring_version: 1,
     // Encodes the runtime semver: major * 1_000_000 + minor * 1_000 + patch.
-    // 0.3.0 -> 3_000. Must stay > the deployed value so the upgrade is
-    // accepted and migrations run (previous release was `2_000`).
-    spec_version: 3_000,
+    // 0.4.0 -> 4_000. Must stay > the deployed value so the upgrade is
+    // accepted and migrations run (previous release was `3_000`).
+    spec_version: 4_000,
     impl_version: 0,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 2,

runtimes/web3-storage-paseo/src/lib.rs

@@ -15,20 +15,25 @@ use crate::{
     AccountId, Balance, Balances, BlockNumber, Runtime, RuntimeEvent,
 };
 
+// Storage-backed parameters: each value below is the default, but can be
+// overridden at runtime via `system.setStorage` (under sudo/governance) without
+// a runtime upgrade. Useful for tuning previewnet timing without redeploying the
+// wasm. Each `pub storage X` exposes `X::key()` / `X::set()` and reads the
+// current value from unhashed storage, falling back to the default.
 parameter_types! {
-    pub const MinProviderStake: Balance = 1_000 * UNIT;  // 1000 tokens minimum stake
-    pub const ChallengeTimeout: BlockNumber = 48 * HOURS;  // 48 hours to respond
-    pub const SettlementTimeout: BlockNumber = 24 * HOURS;
-    pub const RequestTimeout: BlockNumber = 6 * HOURS;
+    pub storage MinProviderStake: Balance = 1_000 * UNIT;  // 1000 tokens minimum stake
+    pub storage ChallengeTimeout: BlockNumber = 48 * HOURS;
+    pub storage SettlementTimeout: BlockNumber = 24 * HOURS;
+    pub storage RequestTimeout: BlockNumber = 6 * HOURS;
     // 1 token (1e12) per 1 GB (1e9 bytes) = 1000 per byte
-    pub const MinStakePerByte: Balance = 1_000;
-    pub const DefaultCheckpointInterval: BlockNumber = 100;
-    pub const DefaultCheckpointGrace: BlockNumber = 20;
-    pub const CheckpointReward: Balance = 1_000_000_000_000; // 1 token
-    pub const CheckpointMissPenalty: Balance = 500_000_000_000; // 0.5 token
+    pub storage MinStakePerByte: Balance = 1_000;
+    pub storage DefaultCheckpointInterval: BlockNumber = 100;
+    pub storage DefaultCheckpointGrace: BlockNumber = 20;
+    pub storage CheckpointReward: Balance = 1_000_000_000_000; // 1 token
+    pub storage CheckpointMissPenalty: Balance = 500_000_000_000; // 0.5 token
     /// Must be `>= ChallengeTimeout` so any challenge created up to the
     /// announcement block matures before the provider can withdraw stake.
-    pub const DeregisterAnnouncementPeriod: BlockNumber = 48 * HOURS;
+    pub storage DeregisterAnnouncementPeriod: BlockNumber = 48 * HOURS;
 }
 
 /// Treasury account that receives slashed funds.

runtimes/web3-storage-paseo/src/storage.rs

@@ -588,17 +588,9 @@ fn should_update_provider_settings() {
 fn should_register_provider_via_xcm() {
     let account = Sr25519Keyring::Alice;
     let who: AccountId = account.to_account_id();
-    let stake = default_stake();
     let multiaddr: Vec<u8> = b"/ip4/127.0.0.1/tcp/3000".to_vec();
     let public_key = to_provider_public_key(account);
 
-    let register_provider_call =
-        RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
-            multiaddr: multiaddr.clone().try_into().unwrap(),
-            public_key: public_key.clone(),
-            stake,
-        });
-
     ExtBuilder::<Runtime>::default()
         .with_collators(vec![AccountId::from(ALICE)])
         .with_session_keys(vec![(
@@ -611,6 +603,16 @@ fn should_register_provider_via_xcm() {
         .with_tracing()
         .build()
         .execute_with(|| {
+            // `default_stake` reads the storage-backed `MinProviderStake`, so it must
+            // run inside the externalities provided by `execute_with`.
+            let stake = default_stake();
+            let register_provider_call =
+                RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
+                    multiaddr: multiaddr.clone().try_into().unwrap(),
+                    public_key: public_key.clone(),
+                    stake,
+                });
+
             // Alice needs balance for both: paid XCM execution fees and the stake reserve.
             let _ = Balances::deposit_creating(&who, stake.saturating_mul(4));
 
@@ -656,19 +658,23 @@ fn should_register_provider_via_xcm() {
 #[test]
 fn should_add_stake_via_xcm() {
     let alice_on_para = alice_on_sibling_parachain(2_000);
-    let initial_stake = default_stake();
     let extra = 500 * UNIT;
 
-    let register_call =
-        RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
-            multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
-            public_key: to_provider_public_key(Sr25519Keyring::Alice),
-            stake: initial_stake,
-        });
-    let add_stake_call =
-        RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::add_stake { amount: extra });
-
     xcm_test_ext().execute_with(|| {
+        // `default_stake` reads the storage-backed `MinProviderStake`, so it must
+        // run inside the externalities provided by `execute_with`.
+        let initial_stake = default_stake();
+        let register_call =
+            RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
+                multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
+                public_key: to_provider_public_key(Sr25519Keyring::Alice),
+                stake: initial_stake,
+            });
+        let add_stake_call =
+            RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::add_stake {
+                amount: extra,
+            });
+
         // The dispatch origin is the sovereign `AccountId` derived from Alice-on-para.
         let derived: AccountId =
             LocationToAccountHelper::<AccountId, LocationToAccountId>::convert_location(
@@ -713,16 +719,18 @@ fn should_register_provider_via_xcm_from_sibling_parachain() {
     // Use a different para id from `should_add_stake_via_xcm` to make the derived sovereign
     // distinct, even though each test runs in a fresh ext.
     let alice_on_para = alice_on_sibling_parachain(3_000);
-    let stake = default_stake();
-
-    let register_call =
-        RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
-            multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
-            public_key: to_provider_public_key(Sr25519Keyring::Alice),
-            stake,
-        });
 
     xcm_test_ext().execute_with(|| {
+        // `default_stake` reads the storage-backed `MinProviderStake`, so it must
+        // run inside the externalities provided by `execute_with`.
+        let stake = default_stake();
+        let register_call =
+            RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
+                multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
+                public_key: to_provider_public_key(Sr25519Keyring::Alice),
+                stake,
+            });
+
         let derived: AccountId =
             LocationToAccountHelper::<AccountId, LocationToAccountId>::convert_location(
                 alice_on_para.clone().into(),
@@ -760,14 +768,16 @@ fn should_fail_xcm_unpaid_execution_from_unauthorized_origin() {
         }],
     );
 
-    let register_call =
-        RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
-            multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
-            public_key: to_provider_public_key(Sr25519Keyring::Alice),
-            stake: default_stake(),
-        });
-
     xcm_test_ext().execute_with(|| {
+        // `default_stake` reads the storage-backed `MinProviderStake`, so it must
+        // run inside the externalities provided by `execute_with`.
+        let register_call =
+            RuntimeCall::StorageProvider(StorageProviderCall::<Runtime>::register_provider {
+                multiaddr: b"/ip4/127.0.0.1/tcp/3000".to_vec().try_into().unwrap(),
+                public_key: to_provider_public_key(Sr25519Keyring::Alice),
+                stake: default_stake(),
+            });
+
         // `None` fee → `RuntimeHelper` builds an `UnpaidExecution + Transact` message.
         let outcome = RuntimeHelper::<Runtime, AllPalletsWithoutSystem>::execute_as_origin(
             (alice_on_relay, OriginKind::SovereignAccount),