Actually fixed duplicate entries in VS2017

Switched to a hash collection to collect the file list so that we can have constant-time lookup for duplicate checking. Previous solutions were failing for various reasons.

Author: parnic

OpenFileInSolutionPackage.cs

@@ -32,6 +32,19 @@ public bool Equals(ProjectItemWrapper other)
         }
     }
 
+    public class ProjectItemComparer : IEqualityComparer<ProjectItemWrapper>
+    {
+        public bool Equals(ProjectItemWrapper x, ProjectItemWrapper y)
+        {
+            return x.Equals(y);
+        }
+
+        public int GetHashCode(ProjectItemWrapper obj)
+        {
+            return obj.Filename.GetHashCode();
+        }
+    }
+
     /// <summary>
     /// This is the class that implements the package exposed by this assembly.
     ///
@@ -199,13 +212,19 @@ private IEnumerable<ProjectItemWrapper> EnumerateProjectItems(ProjectItems items
 
         private void MenuItemCallback(object sender, EventArgs e)
         {
-            var projItems = new List<ProjectItemWrapper>();
+            var projItems = new Dictionary<string, ProjectItemWrapper>(StringComparer.Ordinal);
             foreach (var proj in GetProjects())
             {
-                projItems.AddRange(EnumerateProjectItems(proj.ProjectItems));
+                foreach (var item in EnumerateProjectItems(proj.ProjectItems))
+                {
+                    if (!projItems.ContainsKey(item.Filename))
+                    {
+                        projItems.Add(item.Filename, item);
+                    }
+                }
             }
 
-            var wnd = new ListFiles(projItems);
+            var wnd = new ListFiles(projItems.Values);
             wnd.Owner = HwndSource.FromHwnd(new IntPtr(GetActiveIDE().MainWindow.HWnd)).RootVisual as System.Windows.Window;
             wnd.Width = wnd.Owner.Width / 2;
             wnd.Height = wnd.Owner.Height / 3;

Properties/AssemblyInfo.cs

@@ -29,8 +29,8 @@
 // You can specify all the values or you can default the Revision and Build Numbers 
 // by using the '*' as shown below:
 
-[assembly: AssemblyVersion("1.11.3.0")]
-[assembly: AssemblyFileVersion("1.11.3.0")]
+[assembly: AssemblyVersion("1.11.4.0")]
+[assembly: AssemblyFileVersion("1.11.4.0")]
 
 
 

source.extension.vsixmanifest

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="6bb18fff-9e74-4deb-97df-6a94ddafb74e" Version="1.11.3" Language="en-US" Publisher="Pernicious Games" />
+    <Identity Id="6bb18fff-9e74-4deb-97df-6a94ddafb74e" Version="1.11.4" Language="en-US" Publisher="Pernicious Games" />
     <DisplayName>OpenFileInSolution</DisplayName>
     <Description>Shows a list of all files in the current solution and allows quickly filtering and opening them.</Description>
     <License>LICENSE</License>