fix: reconnect after receiving a goaway

Author: ionutmanolache-okta

lib/client.js

@@ -35,6 +35,8 @@ module.exports = function (dependencies) {
 
   function Client(options) {
     this.isDestroyed = false;
+    this.isSessionReady = false;
+    this.isManageChannelSessionReady = false;
     this.config = config(options);
     this.logger = defaultLogger;
     this.errorLogger = defaultErrorLogger;
@@ -191,6 +193,7 @@ module.exports = function (dependencies) {
     if (path.includes('/1/apps/')) {
       // Connect manageChannelsSession.
       if (
+        !this.isManageChannelSessionReady ||
         !this.manageChannelsSession ||
         this.manageChannelsSession.closed ||
         this.manageChannelsSession.destroyed
@@ -244,7 +247,7 @@ module.exports = function (dependencies) {
       }
     } else {
       // Connect to standard session.
-      if (!this.session || this.session.closed || this.session.destroyed) {
+      if (!this.isSessionReady || !this.session || this.session.closed || this.session.destroyed) {
         try {
           await this.connect();
         } catch (error) {
@@ -378,27 +381,31 @@ module.exports = function (dependencies) {
         this.config
       ));
 
-      if (this.logger.enabled) {
-        this.session.on('connect', () => {
+      this.session.on('connect', () => {
+        this.isSessionReady = true;
+        if (this.logger.enabled) {
           this.logger('Session connected');
-        });
-      }
+        }
+      });
 
       this.session.on('close', () => {
+        this.isSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger('Session closed');
         }
         this.destroySession(session);
       });
 
       this.session.on('error', error => {
+        this.isSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger(`Session error: ${error}`);
         }
         this.closeAndDestroySession(session);
       });
 
       this.session.on('goaway', (errorCode, lastStreamId, opaqueData) => {
+        this.isSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger(
             `GOAWAY received: (errorCode ${errorCode}, lastStreamId: ${lastStreamId}, opaqueData: ${opaqueData})`
@@ -408,6 +415,7 @@ module.exports = function (dependencies) {
       });
 
       this.session.on('frameError', (frameType, errorCode, streamId) => {
+        this.isSessionReady = false;
         // This is a frame error not associate with any request(stream).
         if (this.errorLogger.enabled) {
           this.errorLogger(
@@ -457,34 +465,39 @@ module.exports = function (dependencies) {
         config
       ));
 
-      if (this.logger.enabled) {
-        this.manageChannelsSession.on('connect', () => {
+      this.manageChannelsSession.on('connect', () => {
+        this.isManageChannelSessionReady = true;
+        if (this.logger.enabled) {
           this.logger('ManageChannelsSession connected');
-        });
-      }
+        }
+      });
 
       this.manageChannelsSession.on('close', () => {
+        this.isManageChannelSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger('ManageChannelsSession closed');
         }
         this.destroySession(session);
       });
 
       this.manageChannelsSession.on('socketError', error => {
+        this.isManageChannelSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger(`ManageChannelsSession Socket error: ${error}`);
         }
         this.closeAndDestroySession(session);
       });
 
       this.manageChannelsSession.on('error', error => {
+        this.isManageChannelSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger(`ManageChannelsSession error: ${error}`);
         }
         this.closeAndDestroySession(session);
       });
 
       this.manageChannelsSession.on('goaway', (errorCode, lastStreamId, opaqueData) => {
+        this.isManageChannelSessionReady = false;
         if (this.errorLogger.enabled) {
           this.errorLogger(
             `ManageChannelsSession GOAWAY received: (errorCode ${errorCode}, lastStreamId: ${lastStreamId}, opaqueData: ${opaqueData})`
@@ -494,6 +507,7 @@ module.exports = function (dependencies) {
       });
 
       this.manageChannelsSession.on('frameError', (frameType, errorCode, streamId) => {
+        this.isManageChannelSessionReady = false;
         // This is a frame error not associate with any request(stream).
         if (this.errorLogger.enabled) {
           this.errorLogger(