Transient Error: apn write failed: New streams cannot be created after receiving a GOAWAY

[ionutmanolache-okta]

We use node-apn version 7.1.0 (latest published at the time of writing), and we are observing the following transient error:
apn write failed: New streams cannot be created after receiving a GOAWAY

The error is self explanatory, the client attempts to write after receiving a goaway.

This can happen in the following scenario:

1. for whatever reason (maintenance, throttling, concurrency limit, etc..), the server initiates a goaway
2. the client proceeds with closing and destroying the session
3. meanwhile a new push notification is sent and write is called
4. line 174 and line 234 are can be evaluated to false, so the client tries to send a request on a closing session

The fix:

1. At the very least, we should retry this transient error: PR: fix: Retry transient write failures after receiving goaway #200
2. The client should not initiate any further requests on a closing HTTP/2 session after a goaway is received. In other words, line 174 and line 234 should evaluate if the session is still active (not closing, not closed, not destroyed). PR: fix: Reconnect after receiving goaway #202

We will fork the repo internally and test the fix in production under load, and once the errors disappear, we would like to bring the fix upstream.

[parse-github-assistant]

🚀 Thanks for opening this issue!

[mtrezza]

@ionutmanolache-okta You mentioned that you will try the fix under load in your environment. How did that turn out?