Skip to content

refactor: Bump basic-ftp from 5.2.0 to 5.2.1#3330

Closed
dependabot[bot] wants to merge 1 commit intoalphafrom
dependabot/npm_and_yarn/basic-ftp-5.2.1
Closed

refactor: Bump basic-ftp from 5.2.0 to 5.2.1#3330
dependabot[bot] wants to merge 1 commit intoalphafrom
dependabot/npm_and_yarn/basic-ftp-5.2.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 8, 2026

Bumps basic-ftp from 5.2.0 to 5.2.1.

Release notes

Sourced from basic-ftp's releases.

5.2.1

Changelog

Sourced from basic-ftp's changelog.

5.2.1

Commits
  • ba40f9d Update dev dependencies
  • 6b0008b Bump version
  • 2ecc8e2 Reject control character injection attempts using paths
  • 515d21f Update security policy and reporting instructions
  • 9744254 Link to security advisory
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by patrickjuchli, a new releaser for basic-ftp since your current version.

Install script changes

This version adds prepare script that runs during installation. Review the package contents before updating.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Summary by CodeRabbit

  • Chores
    • Updated basic-ftp to version 5.2.1
    • Removed unnecessary nested dependency from the lock file

@dependabot dependabot bot added dependencies Bot label; pull requests that updates a dependency file javascript Pull requests that update javascript code labels Apr 8, 2026
@parse-github-assistant
Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: bump basic-ftp from 5.2.0 to 5.2.1 refactor: Bump basic-ftp from 5.2.0 to 5.2.1 Apr 8, 2026
@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Apr 10, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d81095c7-fd87-40c5-a204-b62f085715ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated the basic-ftp package in package-lock.json from version 5.2.0 to 5.2.1 with new resolution URL and integrity hash. Removed a nested TypeScript 5.9.3 dependency block from the filing-cabinet node_modules folder.

Changes

Cohort / File(s) Summary
Dependency Update
package-lock.json
Upgraded basic-ftp from 5.2.0 to 5.2.1; removed nested filing-cabinet/node_modules/typescript (v5.9.3) dependency entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing required sections (Issue and Approach) specified in the repository template, though it includes detailed dependency information from Dependabot. Add an 'Issue' section describing the security fix and an 'Approach' section explaining why this dependency bump is needed. Include the Tasks checklist if applicable.
Engage In Review Feedback ⚠️ Warning The pull request has not engaged with the review feedback regarding a critical CI blocker: npm ci is failing due to package.json and package-lock.json being out of sync. Implement the reviewer's feedback by regenerating package-lock.json via npm ci or npm install, committing the updated file, and re-running CI to verify it passes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title uses the 'refactor:' prefix and clearly describes the main change of bumping the basic-ftp dependency version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed The PR updates basic-ftp dependency from 5.2.0 to 5.2.1 to address security vulnerability GHSA-chqc-8p9q-pq6q related to control character injection in file paths.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/npm_and_yarn/basic-ftp-5.2.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Apr 10, 2026

@dependabot rebase

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 10, 2026

Looks like this PR is already up-to-date with alpha! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Apr 10, 2026

@dependabot recreate

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package-lock.json`:
- Around line 12559-12561: package-lock.json is out of sync with package.json
(CI failing with "Missing: typescript@5.9.3 from lock file"); regenerate a clean
lockfile using the same npm major as CI so installs are deterministic. Delete
node_modules and package-lock.json (or run npm install --package-lock-only) then
run npm install with the CI npm version (or run npm ci locally after ensuring
npm version parity) to produce an updated package-lock.json that includes
typescript@5.9.3 and the bumped basic-ftp entry; commit the regenerated
package-lock.json and re-run CI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 98375deb-e82f-4f06-876e-d96902d0873a

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2b612 and f0eab33.

📒 Files selected for processing (1)
  • package-lock.json

Comment on lines +12559 to +12561
"version": "5.2.1",
"resolved": "https://registry.npmjs.org/basic-ftp/-/basic-ftp-5.2.1.tgz",
"integrity": "sha512-0yaL8JdxTknKDILitVpfYfV2Ob6yb3udX/hK97M7I3jOeznBNxQPtVvTUtnhUkyHlxFWyr5Lvknmgzoc7jf+1Q==",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Restore lockfile consistency before merge (CI blocker).

npm ci is currently failing because package.json and package-lock.json are out of sync (Missing: typescript@5.9.3 from lock file). Even though this hunk correctly bumps basic-ftp, the lockfile state is incomplete and must be regenerated so CI can install deterministically.

A clean fix is to regenerate and commit package-lock.json from the current package.json (same npm major as CI), then re-run CI.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package-lock.json` around lines 12559 - 12561, package-lock.json is out of
sync with package.json (CI failing with "Missing: typescript@5.9.3 from lock
file"); regenerate a clean lockfile using the same npm major as CI so installs
are deterministic. Delete node_modules and package-lock.json (or run npm install
--package-lock-only) then run npm install with the CI npm version (or run npm ci
locally after ensuring npm version parity) to produce an updated
package-lock.json that includes typescript@5.9.3 and the bumped basic-ftp entry;
commit the regenerated package-lock.json and re-run CI.

Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/patrickjuchli/basic-ftp/releases)
- [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md)
- [Commits](patrickjuchli/basic-ftp@v5.2.0...v5.2.1)

---
updated-dependencies:
- dependency-name: basic-ftp
  dependency-version: 5.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/basic-ftp-5.2.1 branch from f0eab33 to 44dca87 Compare April 10, 2026 18:44
@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Apr 10, 2026

Closing: Dependabot generated an incomplete package-lock.json that is missing typescript@5.9.3 (nested dependency), causing npm ci to fail on Node 20, Node 22, and Docker. This persists even after @dependabot recreate. The alpha branch CI passes, so this is specific to Dependabot's lock file generation for this update. A new Dependabot PR can be opened if the issue resolves itself, or this transitive update (basic-ftp 5.2.0 to 5.2.1) can be picked up in a future lock file refresh.

@mtrezza mtrezza closed this Apr 10, 2026
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 10, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/basic-ftp-5.2.1 branch April 10, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Bot label; pull requests that updates a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant