Skip to content

fix: Load info panel data when opened over an existing selection#3384

Open
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/3348-info-panel-open-selection
Open

fix: Load info panel data when opened over an existing selection#3384
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/3348-info-panel-open-selection

Conversation

@dblythy

@dblythy dblythy commented Jul 4, 2026

Copy link
Copy Markdown
Member

Closes #3348

Before

Cell selected + panel opened → panel shows "No object selected."

before

After

Panel loads the selected row's data immediately on open.

after

Summary by CodeRabbit

  • Bug Fixes
    • Opening the aggregation panel now refreshes details for the currently selected item, so the info panel stays populated when a selection already exists.
    • Existing selections are now reloaded automatically when the panel becomes visible, improving consistency after toggling the panel.

@parse-github-assistant

Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant Bot changed the title fix: load info panel data when opened over an existing selection fix: Load info panel data when opened over an existing selection Jul 4, 2026
@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 901d6f29-430d-4686-8c3c-d2bf2917e08b

📥 Commits

Reviewing files that changed from the base of the PR and between 9db24be and 4afc70c.

📒 Files selected for processing (1)
  • src/dashboard/Data/Browser/DataBrowser.react.js

📝 Walkthrough

Walkthrough

This change updates togglePanelVisibility in DataBrowser.react.js to re-invoke handleCallCloudFunction for the currently selected object when the aggregation panel is opened with an existing selection, ensuring the info panel loads content immediately rather than remaining empty.

Changes

Info Panel Refresh Fix

Layer / File(s) Summary
Refresh panel data on toggle with existing selection
src/dashboard/Data/Browser/DataBrowser.react.js
togglePanelVisibility now checks if newVisibility is true and selectedObjectId exists, setting showAggregatedData to true and re-calling handleCallCloudFunction to populate the panel.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Engage In Review Feedback ⚠️ Warning Only one commit is present and there’s no evidence of discussion or follow-up on review feedback before the fix landed. Reply to review comments, discuss any disagreements, then resolve them after committing the requested change or getting retraction.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and correctly describes the fix, and it uses the required "fix:" prefix.
Description check ✅ Passed The description covers the issue and approach, but it does not follow the template headings and omits the Tasks section.
Linked Issues check ✅ Passed The change matches issue #3348 by loading the info panel data when opening over an existing selection.
Out of Scope Changes check ✅ Passed The PR stays focused on the panel-open selection bug and shows no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Only adds a conditional refetch for an already-selected object; no new unsafe sink, injection path, or other security-sensitive pattern detected.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@dblythy

dblythy commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Info panel not detecting selection when opened

1 participant