Skip to content

fix: Return to previous class when navigating back after Related records#3385

Open
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/3349-related-records-back-nav
Open

fix: Return to previous class when navigating back after Related records#3385
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/3349-related-records-back-nav

Conversation

@dblythy

@dblythy dblythy commented Jul 4, 2026

Copy link
Copy Markdown
Member

Closes #3349

After navigating A→B via Related records and pressing Back:

Before After
before after

Summary by CodeRabbit

  • Bug Fixes
    • Updated the toolbar experience to show a simpler header without the back-link behavior.
    • Browser navigation now updates the current view more cleanly instead of creating extra history entries.
    • Minor toolbar styling adjustments were made to keep the layout consistent with the updated header.

@parse-github-assistant

Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant Bot changed the title fix: return to previous class when navigating back after Related records fix: Return to previous class when navigating back after Related records Jul 4, 2026
@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: baaa3dfc-4705-489a-9eb9-b9a6d34aeecb

📥 Commits

Reviewing files that changed from the base of the PR and between 9db24be and cb0cad0.

📒 Files selected for processing (4)
  • src/components/Toolbar/Toolbar.react.js
  • src/components/Toolbar/Toolbar.scss
  • src/dashboard/Data/Browser/Browser.react.js
  • src/dashboard/Data/Browser/BrowserToolbar.react.js
💤 Files with no reviewable changes (3)
  • src/dashboard/Data/Browser/BrowserToolbar.react.js
  • src/components/Toolbar/Toolbar.scss
  • src/components/Toolbar/Toolbar.react.js

📝 Walkthrough

Walkthrough

The back-button/navigation UI is removed from the Toolbar component and its stylesheet, the relation propType and prop wiring are removed, and Browser's URL updates now use navigate(..., { replace: true }) instead of pushing a new history entry.

Changes

Toolbar Back-Button Removal and Navigation Update

Layer / File(s) Summary
Toolbar back-button and propTypes cleanup
src/components/Toolbar/Toolbar.react.js
Removes conditional back-button rendering logic and the relation propType declaration.
Toolbar stylesheet cleanup
src/components/Toolbar/Toolbar.scss
Removes .nav display override and top-level .nav/.iconButton style blocks, keeping .titleText visibility rules.
Prop wiring and history navigation change
src/dashboard/Data/Browser/BrowserToolbar.react.js, src/dashboard/Data/Browser/Browser.react.js
Removes relation/filters props passed to Toolbar and changes updateURL() to replace the current history entry instead of pushing a new one.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description references #3349 and includes screenshots, but it lacks the template's Issue, Approach, and Tasks sections. Add the missing Issue, Approach, and Tasks sections and briefly describe the implementation and testing status.
Linked Issues check ⚠️ Warning The changes are related to #3349, but removing back-button history handling appears to conflict with restoring collection A on Back. Rework navigation so related-records opens B without losing A's prior state, and verify the header Back returns exactly to collection A.
Engage In Review Feedback ❓ Inconclusive GitHub issue/commit pages show no review comments or discussion, so engagement can't be verified. Need the PR review thread or comment history to confirm feedback was discussed and then addressed by commit or retraction.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required fix: prefix and accurately summarizes the back-navigation change.
Out of Scope Changes check ✅ Passed All file changes stay within the related-records back-navigation fix and toolbar/browser URL handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Only navigation/UI code was removed or switched to replace history; no new untrusted sinks, redirects, eval, or HTML injection paths were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@dblythy

dblythy commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigating back not working after using "Related records" option

1 participant