feat: Display and edit dates in the browser's local time zone#3387
feat: Display and edit dates in the browser's local time zone#3387dblythy wants to merge 1 commit into
Conversation
|
I will reformat the title to use the proper commit message syntax. |
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Issue
Closes #482
Approach
Adds a per-app
useLocalTimeconfig flag. When enabled, dates in the data browser (and other date displays) are shown and edited in the viewer's browser time zone instead of UTC. Dates are always stored in UTC; editing is WYSIWYG, so the local wall-clock you type or pick is converted to UTC on save. The default is unchanged (UTC).This generalizes the existing binary
local/UTC handling (already used for Push scheduling) viadateStringUTC(date, useLocalTime)plus shareddateInputString/parseDateInputhelpers inlib/DateUtils, with no new dependency.local_timetoggle) and the Analytics chart's separate date handling.Display: same rows and server, viewed as UTC vs local
Test browser zone: Australia/Sydney (GMT+11 AEDT / GMT+10 AEST).
13:45:30 UTC→0:45:30 GMT+11(day rolls over);21:00 UTC→7:00 GMT+10; DST is resolved per date.useLocalTimeunset (UTC, unchanged)useLocalTime: true(browser local)Editing is WYSIWYG: edit in local, store in UTC
Editing the
Morningrow in the local app. The inline editor shows the local wall-clock (2020-01-16T00:45:30), changed here to09:00:Committed, so the cell shows
16 Jan 2020, 9:00:00 GMT+11:Stored as UTC (the same instant): the UTC app shows
15 Jan 2020, 22:00:00 UTC(raw REST value2020-01-15T22:00:00.000Z). In the UTC app, typed input without aZis still interpreted as UTC, so the default behavior is unchanged.Tasks