Skip to content

fix: Don't emit a Delete op when clearing a field on a new row (#1751)#3390

Open
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/1751-unset-new-row-delete-op
Open

fix: Don't emit a Delete op when clearing a field on a new row (#1751)#3390
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/1751-unset-new-row-delete-op

Conversation

@dblythy

@dblythy dblythy commented Jul 5, 2026

Copy link
Copy Markdown
Member

Closes #1751

Clearing a field on a not-yet-saved row sent a {"__op":"Delete"} for that field on the create request, which is invalid (the object does not exist yet). The fix omits the field instead, by cloning the unsaved object (which drops the pending Delete op while keeping the remaining attributes).

Verification: create request when clearing a field on a new row, then saving.

Before:

{ "label": { "__op": "Delete" }, ... }

After:

{ ... }   // "label" omitted

Notes:

  • Clearing a field on an already-saved row is unchanged (still sends a real {"__op":"Delete"}), verified in QA and locked in by a unit test.
  • The same path is used for the duplicate/edit-clone unsaved row, so it gets the fix too.
  • On current Parse Server the stray op is tolerated for optional fields, but it still breaks on stricter validation and special fields (e.g. the _User case in the report), and is incorrect regardless.

@parse-github-assistant

Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant Bot changed the title fix: don't emit a Delete op when clearing a field on a new row (#1751) fix: Don't emit a Delete op when clearing a field on a new row (#1751) Jul 5, 2026
@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 314a5ee9-d38f-4d2f-9bd8-352652744b69

📥 Commits

Reviewing files that changed from the base of the PR and between 9db24be and d6a63c2.

📒 Files selected for processing (3)
  • src/dashboard/Data/Browser/Browser.react.js
  • src/lib/tests/unsetField.test.js
  • src/lib/unsetField.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not save new _User object after deleting field value

1 participant