fix: Render Date value in non-Date column instead of crashing (#1927)#3395
fix: Render Date value in non-Date column instead of crashing (#1927)#3395dblythy wants to merge 1 commit into
Conversation
|
I will reformat the title to use the proper commit message syntax. |
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Closes #1927
Problem
If a column named
expiresAtis added to a class with a type other than Date (e.g. String) and given a value, the data browser renders a blank/white page. The console shows:React error #31 is "Objects are not valid as a React child": a
Dateobject is being rendered directly into JSX.Root cause
expiresAtis a reserved Parse field name. Parse Server coerces it to a Date on read regardless of the column type the schema declares:The Parse JS SDK decodes that into a real
Dateinstance, so the data browser receivesvalue = <Date>while the cell'stypeprop isString.BrowserCell.renderCellContent()keys its whole if/else chain offthis.props.typeand has no default branch, so fortype === 'String'nothing matches and the rawDateobject is set as the cell content and rendered as a JSX child, crashing the tree.Fix
src/components/BrowserCell/BrowserCell.react.js:Datevalue as a formatted string (via the existingdateStringUTChelper) even when the declared column type is notDate, so a Date reaching a non-Date column no longer crashes.type === 'Date'branch: its guards tested an out-of-scopevaluevariable (alwaysundefined), so the{__type:'Date', iso}/ string conversions were dead code and mutated the read-onlythis.props.value. It now uses a local variable, so a Date-typed column given a{__type}/string value is handled instead of throwing.Verification
Added
src/lib/tests/BrowserCell.test.jscases (red→green): a Date value in a non-Date column renders as a string without throwing, and a Date-typed column given a date string renders without throwing.Runtime, class with a String
expiresAtcolumn and value"2001-01-01":Before: opening the class blanks the whole page; console logs
Objects are not valid as a React child (found: Mon Jan 01 2001 …):After: the browser loads and the
expiresAtcell shows the formatted date; no console errors: