Skip to content

fix: Add delete control for file fields in the edit dialog (#1832)#3396

Open
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/1832-file-delete-button
Open

fix: Add delete control for file fields in the edit dialog (#1832)#3396
dblythy wants to merge 1 commit into
parse-community:alphafrom
dblythy:fix/1832-file-delete-button

Conversation

@dblythy

@dblythy dblythy commented Jul 5, 2026

Copy link
Copy Markdown
Member

Closes #1832

Problem

Under the modern UI, a File field in the row edit modal can be downloaded and replaced but not
removed with a click. The pre-3.2.0 UI had a Delete button; it was dropped, and the modal offers no
way to unset a file (only the data-browser Delete key unsets a field). This matches the issue's
final diagnosis that the modal "behaves differently than the data browser" and needs a per-field
unset affordance.

Fix

Add a "Delete file" control (a Pill, rendered only when a file exists) next to "Change file" in the
EditRowDialog File case. It unsets via the existing path: handleChange(undefined, name) ->
updateRow(row, name, undefined) -> Parse.Object.unset() -> save, i.e. exactly the same "unset"
contract the data-browser Delete key already uses, so behaviour is consistent.

Also removes the now-superseded dead code in FileEditor (removeFile() and the fileInputRef it
was the sole reader of): that method already did onCommit(undefined) but was never wired to
anything, and since FileEditor renders display:none (it is a headless native-picker trigger),
the delete control belongs in the dialog where the file UI is actually visible.

Scope: the inline data-browser File cell already supports unset via the Delete key, so only the
modal needed a click affordance.

Verification

Added src/lib/tests/EditRowDialog.test.js (red->green): asserts the "Delete file" Pill renders only
when a file is present and that clicking it calls updateRow(row, name, undefined).

Runtime, class TestFiles with a photo File column holding an uploaded file, opened via
Edit > "Edit this row with modal":

Before: the File field shows only the download arrow + "Change file"; no way to delete the file.

Before: no delete control

After: a "Delete file" control appears next to "Change file".

After: delete control present

Clicking "Delete file" unsets the field (shows "Select file"; the cell reads "(undefined)" and the
server no longer returns the photo key):

After: file removed

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 066718db-2801-4cf7-8eb0-13ed87eb52b5

📥 Commits

Reviewing files that changed from the base of the PR and between 9db24be and 4768fb2.

📒 Files selected for processing (3)
  • src/components/FileEditor/FileEditor.react.js
  • src/dashboard/Data/Browser/EditRowDialog.react.js
  • src/lib/tests/EditRowDialog.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot delete file from field in modal dialog

1 participant