test: Address CodeRabbit review on GeoPoint specs

- Drop the misleading GeoPointLiteral[] | unknown union on withinPolygon
  (negative-path specs deliberately pass invalid values, so the param is unknown)
- Drop the unnecessary masterKey auth in the __type response test
- Filter the sub-object and array specs on a sentinel tag instead of an
  unfiltered find, so they don't depend on global cleanup ordering
- Clarify the seed-point comments (inside / on boundary / outside)

Author: dblythy

spec/helpers/geo.ts

@@ -42,8 +42,12 @@ export function withinGeoBox(southwest: GeoPointLiteral, northeast: GeoPointLite
   return { $within: { $box: [southwest, northeast] } };
 }
 
-/** Search within a polygon, given either a list of points or a Polygon object. */
-export function withinPolygon(polygon: GeoPointLiteral[] | unknown) {
+/**
+ * Search within a polygon, given a list of GeoPoints or a Polygon object.
+ * Typed as `unknown` because the negative-path specs deliberately pass invalid
+ * values (numbers, empty arrays, malformed points) to exercise server validation.
+ */
+export function withinPolygon(polygon: unknown) {
   return { $geoWithin: { $polygon: polygon } };
 }
 

spec/rest/objects/geopoint-polygon.spec.ts

@@ -7,9 +7,9 @@ import { ParseError } from '../../helpers/errors.ts';
 
 function seedPolygonPoints() {
   return createObjects('Polygon', [
-    { location: geoPoint(1.5, 1.5) }, // inbound
-    { location: geoPoint(10, 10) }, // onbound
-    { location: geoPoint(20, 20) }, // outbound
+    { location: geoPoint(1.5, 1.5) }, // inside
+    { location: geoPoint(10, 10) }, // on boundary
+    { location: geoPoint(20, 20) }, // outside
   ]);
 }
 

spec/rest/objects/geopoint.spec.ts

@@ -30,7 +30,7 @@ describe('GeoPoint REST', () => {
       location: geoPoint(44.0, -11.0),
       name: 'Zhoul',
     });
-    const result = await getObject('TestObject', created.objectId, { masterKey: true });
+    const result = await getObject('TestObject', created.objectId);
     expect(result.location.__type).toEqual('GeoPoint');
   });
 
@@ -53,8 +53,11 @@ describe('GeoPoint REST', () => {
   });
 
   it('supports a sub-object with a geo point', async () => {
-    await createObject('TestObject', { subobject: { location: geoPoint(44.0, -11.0) } });
-    const results = await find('TestObject');
+    await createObject('TestObject', {
+      subobject: { location: geoPoint(44.0, -11.0) },
+      tag: 'subobject-geo',
+    });
+    const results = await find('TestObject', { where: { tag: 'subobject-geo' } });
     expect(results.length).toEqual(1);
     const pointAgain = results[0].subobject.location;
     expect(pointAgain).toBeTruthy();
@@ -65,8 +68,8 @@ describe('GeoPoint REST', () => {
   it('supports array of geo points', async () => {
     const point1 = geoPoint(44.0, -11.0);
     const point2 = geoPoint(22.0, -55.0);
-    await createObject('TestObject', { locations: [point1, point2] });
-    const results = await find('TestObject');
+    await createObject('TestObject', { locations: [point1, point2], tag: 'array-geo' });
+    const results = await find('TestObject', { where: { tag: 'array-geo' } });
     expect(results.length).toEqual(1);
     const locations = results[0].locations;
     expect(locations.length).toEqual(2);