test: Harden REST helpers per CodeRabbit review

Use a dedicated maintenance-key value in buildHeaders, assert the Parse-error
shape in expectParseError, drop the redundant local reconfigureServer decl
(it lives in globals.d.ts), and fix the REST-client description in the plan.

Author: dblythy

spec/helpers/config.ts

@@ -5,6 +5,7 @@ export const TestConfig = {
   serverURL: 'http://localhost:8378/1',
   appId: 'test',
   masterKey: 'test',
+  maintenanceKey: 'testing',
   restAPIKey: 'rest',
   clientKey: 'client',
   javascriptKey: 'test',

spec/helpers/headers.ts

@@ -21,7 +21,7 @@ export function buildHeaders(auth: AuthOptions = {}): ParseHeaders {
   const headers: ParseHeaders = { 'X-Parse-Application-Id': TestConfig.appId };
   if (auth.json !== false) headers['Content-Type'] = 'application/json';
   if (auth.masterKey) headers['X-Parse-Master-Key'] = TestConfig.masterKey;
-  if (auth.maintenanceKey) headers['X-Parse-Maintenance-Key'] = TestConfig.masterKey;
+  if (auth.maintenanceKey) headers['X-Parse-Maintenance-Key'] = TestConfig.maintenanceKey;
   if (auth.restAPIKey) headers['X-Parse-REST-API-Key'] = TestConfig.restAPIKey;
   if (auth.clientKey) headers['X-Parse-Client-Key'] = TestConfig.clientKey;
   if (auth.javascriptKey) headers['X-Parse-JavaScript-Key'] = TestConfig.javascriptKey;

spec/helpers/request.ts

@@ -95,6 +95,11 @@ export async function expectParseError(
     await promise;
   } catch (e: any) {
     const body: ParseErrorBody = e && e.data ? e.data : e;
+    if (typeof body?.code !== 'number' || typeof body?.error !== 'string') {
+      throw new Error(
+        `Expected a Parse error ({ code, error }), but got: ${JSON.stringify(body)}`
+      );
+    }
     if (code !== undefined) {
       expect(body.code).toBe(code);
     }

spec/server/analytics.spec.ts

@@ -1,7 +1,5 @@
 import { track, appOpened } from '../helpers/analytics.ts';
 
-declare const reconfigureServer: (config?: Record<string, unknown>) => Promise<unknown>;
-
 describe('AnalyticsController', () => {
   const analyticsAdapter = {
     appOpened: function () {},

spec/spec_migration.md

@@ -65,7 +65,7 @@ Measured at the time of writing — re-measure before starting to confirm.
 | Decision | Choice |
 |---|---|
 | Roll-out | **Incremental, in-place** — convert files where they live, reorganise directories as part of each migration. |
-| Server access | **New typed REST test client** wrapping `lib/request.js`. |
+| Server access | **New typed REST test client** — a small, typed layer over the native `fetch` API (Node 18+). |
 | SDK | **Eliminate the Parse JS SDK** from all HTTP-level tests. Retain only a thin WS client for LiveQuery (not the SDK's LiveQuery client). |
 | Quality | **Full cleanup bundled into each file's migration** — async/await, no `setTimeout` timing, cleanup hooks, monolith splitting, eslint tightening, `xit`/`fit` triage. |
 | Language | **TypeScript** for helpers/clients (and incrementally for specs). |