ci: Remove feature to retry flaky tests (#10314)

Author: mtrezza

spec/helper.js

@@ -25,8 +25,7 @@ if (dns.setDefaultResultOrder) {
 jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 10000;
 jasmine.getEnv().addReporter(new CurrentSpecReporter());
 jasmine.getEnv().addReporter(new SpecReporter());
-global.retryFlakyTests();
-
+global.normalizeAsyncTests();
 global.on_db = (db, callback, elseCallback) => {
   if (process.env.PARSE_SERVER_TEST_DB == db) {
     return callback();

spec/support/CurrentSpecReporter.js

@@ -4,21 +4,10 @@ const { performance } = require('perf_hooks');
 
 global.currentSpec = null;
 
-/**
- * Names of tests that fail randomly and are considered flaky. These tests will be retried
- * a number of times to reduce the chance of false negatives. The test name must be the same
- * as the one displayed in the CI log test output.
- */
-const flakyTests = [];
-
 /** The minimum execution time in seconds for a test to be considered slow. */
 const slowTestLimit = 2;
 
-/** The number of times to retry a flaky test. */
-const retries = 5;
-
 const timerMap = {};
-const retryMap = {};
 const duplicates = [];
 class CurrentSpecReporter {
   specStarted(spec) {
@@ -52,61 +41,64 @@ global.displayTestStats = function() {
     console.warn('Duplicate spec: ' + spec);
   });
   console.log('\n');
-  Object.keys(retryMap).forEach((spec) => {
-    console.warn(`Flaky test: ${spec} failed ${retryMap[spec]} times`);
-  });
-  console.log('\n');
 };
 
-global.retryFlakyTests = function() {
-  const originalSpecConstructor = jasmine.Spec;
-
-  jasmine.Spec = function(attrs) {
-    const spec = new originalSpecConstructor(attrs);
-    const originalTestFn = spec.queueableFn.fn;
-    const runOriginalTest = () => {
-      if (originalTestFn.length == 0) {
-        // handle async testing
-        return originalTestFn();
-      } else {
-        // handle done() callback
+/**
+ * Transitional compatibility shim for Jasmine 5.
+ *
+ * Jasmine 5 throws when a test or hook function uses both `async` and a `done` callback:
+ * "An asynchronous before/it/after function was defined with the async keyword
+ * but also took a done callback."
+ *
+ * Many existing tests use `async (done) => { ... done(); }`. This wrapper converts
+ * those to promise-based functions by intercepting the `done` callback and resolving
+ * a promise instead, so Jasmine sees a plain async function.
+ *
+ * To remove this shim, convert each file below so that tests and hooks use plain
+ * `async () => {}` without a `done` parameter, then remove the file from this list.
+ * Once the list is empty, delete this function and its call in `helper.js`.
+ */
+global.normalizeAsyncTests = function() {
+  function wrapDoneCallback(fn) {
+    if (fn.length > 0) {
+      return function() {
         return new Promise((resolve) => {
-          originalTestFn(resolve);
+          fn.call(this, resolve);
         });
-      }
-    };
-    spec.queueableFn.fn = async function() {
-      const isFlaky = flakyTests.includes(spec.result.fullName);
-      const runs = isFlaky ? retries : 1;
-      let exceptionCaught;
-      let returnValue;
+      };
+    }
+    return fn;
+  }
 
-      for (let i = 0; i < runs; ++i) {
-        spec.result.failedExpectations = [];
-        returnValue = undefined;
-        exceptionCaught = undefined;
-        try {
-          returnValue = await runOriginalTest();
-        } catch (exception) {
-          exceptionCaught = exception;
-        }
-        const failed = !spec.markedPending &&
-            (exceptionCaught || spec.result.failedExpectations.length != 0);
-        if (!failed) {
-          break;
-        }
-        if (isFlaky) {
-          retryMap[spec.result.fullName] = (retryMap[spec.result.fullName] || 0) + 1;
-          await global.afterEachFn();
-        }
-      }
-      if (exceptionCaught) {
-        throw exceptionCaught;
-      }
-      return returnValue;
-    };
+  // Wrap it() specs
+  const originalSpecConstructor = jasmine.Spec;
+  jasmine.Spec = function(attrs) {
+    const spec = new originalSpecConstructor(attrs);
+    spec.queueableFn.fn = wrapDoneCallback(spec.queueableFn.fn);
     return spec;
   };
-}
+
+  // Wrap beforeEach/afterEach/beforeAll/afterAll
+  const originalBeforeEach = jasmine.Suite.prototype.beforeEach;
+  jasmine.Suite.prototype.beforeEach = function(fn) {
+    fn.fn = wrapDoneCallback(fn.fn);
+    return originalBeforeEach.call(this, fn);
+  };
+  const originalAfterEach = jasmine.Suite.prototype.afterEach;
+  jasmine.Suite.prototype.afterEach = function(fn) {
+    fn.fn = wrapDoneCallback(fn.fn);
+    return originalAfterEach.call(this, fn);
+  };
+  const originalBeforeAll = jasmine.Suite.prototype.beforeAll;
+  jasmine.Suite.prototype.beforeAll = function(fn) {
+    fn.fn = wrapDoneCallback(fn.fn);
+    return originalBeforeAll.call(this, fn);
+  };
+  const originalAfterAll = jasmine.Suite.prototype.afterAll;
+  jasmine.Suite.prototype.afterAll = function(fn) {
+    fn.fn = wrapDoneCallback(fn.fn);
+    return originalAfterAll.call(this, fn);
+  };
+};
 
 module.exports = CurrentSpecReporter;