fix: coderabbit suggestions

Author: parmesant

Cargo.toml

@@ -219,7 +219,15 @@ assets-sha1 = "a7523ef819d38678275ae165c443564b2f9a3fc1"
 
 [features]
 debug = []
-hotpath = ["dep:hotpath"]
+hotpath = [
+    "dep:hotpath",
+    "hotpath/hotpath",
+    "hotpath/hotpath-cpu",
+    "hotpath/hotpath-alloc",
+    "hotpath/tokio",
+]
+hotpath-alloc = ["hotpath"]
+hotpath-cpu = ["hotpath"]
 kafka = [
     "rdkafka",
     "rdkafka/ssl-vendored",

src/cli.rs

@@ -559,14 +559,14 @@ pub struct Options {
     )]
     pub max_field_statistics: usize,
 
-    // maximum limit to store the statistics for a field
+    // collect statistics for dataset fields
     #[arg(
         long,
-        env = "P_CALCULATE_FIELD_STATISTICS",
+        env = "P_COLLECT_DATASET_STATS",
         default_value = "true",
-        help = "Maximum number of field statistics to store"
+        help = "Collect statistics for dataset fields"
     )]
-    pub calculate_field_statistics: bool,
+    pub collect_dataset_stats: bool,
 
     #[arg(
         long,

src/main.rs

@@ -32,6 +32,7 @@ use tracing_subscriber::util::SubscriberInitExt;
 use tracing_subscriber::{EnvFilter, Registry, fmt};
 
 #[actix_web::main]
+#[cfg_attr(feature = "hotpath", hotpath::main)]
 async fn main() -> anyhow::Result<()> {
     init_logger();
     // Install the rustls crypto provider before any TLS operations.

src/storage/object_storage.rs

@@ -184,8 +184,8 @@ async fn upload_single_parquet_file(
     let manifest = catalog::create_from_parquet_file(absolute_path, &path)
         .map_err(|e| (path.clone(), ObjectStorageError::from(e)))?;
 
-    if PARSEABLE.options.calculate_field_statistics {
-        // Calculate field stats if enabled
+    if PARSEABLE.options.collect_dataset_stats {
+        // collect field stats if enabled
         calculate_stats_if_enabled(&stream_name, &path, &schema, tenant_id).await;
     }