fix: user auth for datasets#1725
Conversation
reader of all datasets get permission "*" user_auth_for_datasets treat this as literal stream hence query/counts api fail with error stream not found fix: use stream name of request dataset from the request
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe changes refine alert array parsing tests, reformat related code, and update query authorization to validate the requested dataset rather than the permission selector. Filter authorization call formatting is also adjusted without changing its behavior. ChangesAlert parsing coverage
Query dataset authorization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
reader of all datasets get permission "*"
user_auth_for_datasets treat this as literal stream hence query/counts api fail with error stream not found
fix: use stream name of request dataset from the request
Summary by CodeRabbit