BUILD: enable final link via C++#389
Open
0-8-15 wants to merge 1 commit into
Open
Conversation
It also links some files into a position where they are expected. No idea how to do this the right way(TM).
mgorges
reviewed
Nov 4, 2020
| win_sysroot=`ls -1d ${WIN32SDK}/i?86-*mingw32* | head -n 1` | ||
| win_cross=`ls -1 ${WIN32SDK}/bin/*mingw32*-gcc | head -n 1 | sed 's/gcc$//'` | ||
|
|
||
| test -f ${SYS_PREFIX}/include/WinSock2.h || ln -s $win_sysroot/include/winsock2.h ${SYS_PREFIX}/include/WinSock2.h |
Contributor
There was a problem hiding this comment.
Why are you doing this instead of adding another -I$win_sysroot/include in targets/win32/build-binary#L89? Also, does this filename case matter?
mgorges
reviewed
Nov 4, 2020
| if [ `is_gui_app` = yes ]; then | ||
| veval "$SYS_CC -I$SYS_PREFIX/include \ | ||
| $cflag_additions -mwindows win32_microgl.c main.c icon.o -o $tgt \ | ||
| $cflag_additions -mwindows -fpermissive win32_microgl.c main.c icon.o -o $tgt \ |
Contributor
There was a problem hiding this comment.
Shouldn't the -fpermissive also only be applied when using a c++ compiler, as I thought this was only needed if you use non-conforming code?
Contributor
Author
|
Am Wed, 04 Nov 2020 00:44:39 -0800
schrieb Matthias Görges <notifications@github.com>:
@mgorges commented on this pull request.
> @@ -38,6 +38,11 @@
win_sysroot=`ls -1d ${WIN32SDK}/i?86-*mingw32* | head -n 1`
win_cross=`ls -1 ${WIN32SDK}/bin/*mingw32*-gcc | head -n 1 | sed
's/gcc$//'`
+test -f ${SYS_PREFIX}/include/WinSock2.h || ln -s
$win_sysroot/include/winsock2.h ${SYS_PREFIX}/include/WinSock2.h
Why are you doing this instead of adding another
`-I$win_sysroot/include` in targets/win32/build-binary#L89?
because I did not find the right spot to do such a thing
at the other hand: I'd rather not need such a shitty hack at all
Also, does this filename case matter?
That's been the issue behind: I cross-compile for Win32 under Linux.
That's when it failed to work.
|
Contributor
Author
|
Am Wed, 04 Nov 2020 00:45:55 -0800
schrieb Matthias Görges <notifications@github.com>:
@mgorges commented on this pull request.
> @@ -87,7 +87,7 @@ if [ `is_standalone_app` = "yes" ]; then
else
if [ `is_gui_app` = yes ]; then
veval "$SYS_CC -I$SYS_PREFIX/include \
- $cflag_additions -mwindows win32_microgl.c main.c icon.o -o
$tgt \
+ $cflag_additions -mwindows -fpermissive win32_microgl.c main.c
icon.o -o $tgt \
Shouldn't the `-fpermissive` also only be applied when using a c++
compiler, as I thought this was only needed if you use non-conforming
code?
Likely it should. Again just a bad work around the actual issue: maybe
someone knows how to fix the offending lines in the source code in a
way compatible with both dialects.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also links some files into a position where they are expected.
No idea how to do this the right way(TM).