test: add date_trunc DST regression test#3
Open
andygrove wants to merge 3 commits into
Open
Conversation
Exercises CometTruncTimestamp natively (via allowIncompatible=true) with a session timezone that observes DST. Covers spring-forward and fall-back transition days across DAY, HOUR, WEEK, MONTH, QUARTER, and YEAR levels, plus baseline non-DST days.
parthchandra
force-pushed
the
complete_ntz
branch
2 times, most recently
from
85c31e8 to
aebca12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a SQL file-based test that exercises
date_truncnatively on a DST-observing session timezone (America/Los_Angeles) withspark.comet.expression.TruncTimestamp.allowIncompatible=true. It covers both DST transition days (2024-03-10 spring-forward, 2024-11-03 fall-back) along with non-DST baseline days, and all supported truncation levels.Running this test against the current branch shows the native result diverging from Spark on DST days for
DAYtruncation. Example from a local run:The test is intended to pin down the DST behaviour of the
as_micros_from_unix_epoch_utcchange so it can be iterated on before merging.Run with: