refactor(analysis): unify profile parsing and diagnostics snapshots#300
Merged
Conversation
|
Docs preview: https://vide.pascal-lab.net/preview/pr-300/ |
hongjr03
force-pushed
the
refactor/analysis-snapshot
branch
from
0fd90ad to
5a4d1d3
Compare
FileId's field is private on master after #301; update tests and silence clippy too_many_arguments on snapshot/key constructors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify profile compilation parsing around analysis snapshot context, so parsing, semantic compilation, and diagnostics share one consistent snapshot lifecycle. This removes redundant document revisions and standalone source parsing, reuses cached profile analysis and syntax trees, and adds the Slang FFI access needed to retain source metadata without keeping unnecessary syntax trees alive.
Diagnostics are now owned by the active analysis snapshot and preserve profile
vidediagnostics across updates, ensuring results always correspond to the snapshot that produced them. The change also updates coverage for parse reuse, preprocessing behavior, and snapshot freshness, and adds tracing for profile-root parsing.