Skip to content

Commit 488ba3c

Browse files
committed
ft-orchestration mak appply_loop_offsets configurable per profile and per test-case
1 parent e4e06dc commit 488ba3c

4 files changed

Lines changed: 14 additions & 4 deletions

File tree

tools/ft-analyzer/ftanalyzer/replicator/flow_replicator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ def _recommend_chunksize(self) -> int:
746746
rows = max(1000, int(budget // max(1, bytes_per_row)))
747747
return rows
748748

749-
def _estimate_memory_from_file(csv_path: str, column_types: dict):
749+
def _estimate_memory_from_file(self, csv_path: str, column_types: dict):
750750
bytes_per_row = sum(
751751
np.dtype(t).itemsize
752752
for t in column_types.values()

tools/ft-orchestration/tests/simulation/test_simulation_general.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def finalizer_download_logs():
337337
scenario.test.get_prefilter_conf(scenario.default),
338338
scenario.test.loops,
339339
scenario.test.get_replicator_units(scenario.sampling),
340-
scenario.test.apply_loop_offsets,
340+
scenario.default.apply_loop_offsets and scenario.test.apply_loop_offsets,
341341
)
342342
if len(prefilter_conf) > 0:
343343
probe_instance.set_prefilter(prefilter_conf)
@@ -381,6 +381,9 @@ def finalizer_download_logs():
381381
input_file=ref_file,
382382
loops=scenario.test.loops,
383383
generator_stats=stats,
384+
merge_across_loops=not (
385+
scenario.default.apply_loop_offsets and scenario.test.apply_loop_offsets
386+
),
384387
speed_multiplier=speed.speed if isinstance(speed, MultiplierSpeed) else 1.0,
385388
)
386389

tools/ft-orchestration/tests/simulation/test_simulation_overload.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ def finalizer_download_logs():
282282
generator_conf,
283283
scenario.test.multiplier,
284284
int(1 / scenario.sampling),
285-
scenario.test.apply_loop_offsets,
285+
scenario.default.apply_loop_offsets and scenario.test.apply_loop_offsets,
286286
)
287287
speed = (
288288
scenario.test.speed_multiplier
@@ -320,6 +320,9 @@ def finalizer_download_logs():
320320
flow_replicator.replicate,
321321
input_file=ref_file,
322322
loops=LOOPS,
323+
merge_across_loops=not (
324+
scenario.default.apply_loop_offsets and scenario.test.apply_loop_offsets
325+
),
323326
generator_stats=stats,
324327
speed_multiplier=speed.speed if isinstance(speed, MultiplierSpeed) else 1.0,
325328
)

tools/ft-orchestration/tests/simulation/test_simulation_threshold.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ def run_single_test(
254254
generator_conf,
255255
loops,
256256
replicator_units,
257-
scenario.test.apply_loop_offsets,
257+
scenario.default.apply_loop_offsets and scenario.test.apply_loop_offsets,
258258
)
259259
generator_instance.start_profile(
260260
profile_path,
@@ -284,6 +284,10 @@ def run_single_test(
284284
flow_replicator.replicate,
285285
input_file=ref_file,
286286
loops=loops,
287+
merge_across_loops=not (
288+
scenario.default.apply_loop_offsets
289+
and scenario.test.apply_loop_offsets
290+
),
287291
generator_stats=stats,
288292
)
289293

0 commit comments

Comments
 (0)