fix(release): add missing nodes package to release workflow#471
Open
bo-hyeon wants to merge 1 commit into
Open
fix(release): add missing nodes package to release workflow#471bo-hyeon wants to merge 1 commit into
bo-hyeon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the missing
nodespackage to the release workflow.@pascal-app/nodeswas split out into its own package but never addedto this workflow's
packagechoice list or publish steps, so it hasnever been publishable to npm — that's the root cause of npm-only
installs rendering nothing on 0.9.x (empty nodeRegistry).
This mirrors the existing core/viewer pattern: adds
nodesto everyloop that iterates packages, and adds a "Build & publish nodes" step.
Fixes #454
Note
Low Risk
CI/release workflow only; no runtime or application code changes.
Overview
Wires
@pascal-app/nodesinto the manual release workflow so it can be version-bumped, built, and published like the other packages.The workflow dispatch package choice now includes
nodes, and every shell loop that bumps versions and syncs@pascal-app/*peerDependencies / devDependencies treatsnodesthe same as core, viewer, editor, mcp, and ifc-converter. A new Build & publish nodes step runsbun run buildinpackages/nodesand publishes with dry-run support, and the commit/tag step recordsNODES_VERSIONwhen that package is released.This closes the gap where the split-out nodes package was never on npm—matching the PR’s link to empty nodeRegistry on npm-only 0.9.x installs.
Reviewed by Cursor Bugbot for commit ee0a4df. Bugbot is set up for automated code reviews on this repo. Configure here.